Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It is possible to create hundreds of temporary articles in the server using TM. #697

Closed
michaelhidalgo opened this issue Apr 14, 2015 · 8 comments
Assignees

Comments

@michaelhidalgo
Copy link
Contributor

It seems like when we provide a non-existing article, GraphDB creates a temporary file in the /.tmCache/data_cache folder.

Someone might run a script and full the disk with files :

Here is the folder empty :

screen shot 2015-04-14 at 9 42 14 am

Creating a script to target TM

  runTest = (articleUrl) ->
    testName = articleUrl
    it testName, (done) ->
      jade.login_As_User ()->
        page.open articleUrl, (html,$)->
          page.wait_For_Complete (html, $)=>
          done()

  x =0
  while x < 500
    url = "/article/query-".add_5_Letters()
    runTest(url)
    x++

and this is the result

screen shot 2015-04-14 at 9 51 49 am

@michaelhidalgo
Copy link
Contributor Author

@DinisCruz
Copy link
Contributor

that is a bug, in fact that is most likely the reason for the #682 prob

we need to fix it here https://github.com/TeamMentor/TM_4_0_GraphDB/blob/master/src/api/Data-API.coffee#L17

DinisCruz added a commit to TeamMentor/TM_GraphDB that referenced this issue Apr 14, 2015
Note that this is not the best way to solve that issue since we still have TeamMentor/TM_4_0_Design#697
michaelhidalgo added a commit to michaelhidalgo/TM_4_0_GraphDB that referenced this issue Apr 15, 2015
It is possible to create hundreds of temporary articles in the server using TM
michaelhidalgo added a commit to michaelhidalgo/TM_4_0_GraphDB that referenced this issue Apr 15, 2015
DinisCruz added a commit to TeamMentor/TM_GraphDB that referenced this issue Apr 21, 2015
@DinisCruz
Copy link
Contributor

I just merged TeamMentor/TM_GraphDB#5

@michaelhidalgo can you run your script again and confirm that the temp files are not created

@DinisCruz
Copy link
Contributor

added to #703

DinisCruz added a commit to TeamMentor/TM_QA that referenced this issue Apr 21, 2015
@michaelhidalgo
Copy link
Contributor Author

Thanks Dinis, sure let me give it a test.

El martes, 21 de abril de 2015, Dinis Cruz [email protected]
escribió:

added to #703 #703


Reply to this email directly or view it on GitHub
#697 (comment)
.

Sent from Gmail Mobile

@michaelhidalgo
Copy link
Contributor Author

This issue seems to be fixed :
I ran simultaneous request (with Fiddler by incrementing by 1 the id of the URL using the # feature).
screen shot 2015-04-22 at 09 48 34

Then I checked the temp folder and no articles were created

screen shot 2015-04-22 at 09 50 27

@michaelhidalgo
Copy link
Contributor Author

closing this.

@DinisCruz
Copy link
Contributor

nice, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants