Fix "None on top" sort mode #3966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TranceLove
added
Issue-Bug
TranceLove
changed the title
|
Necessary work should be adequate; but I shall let you decide if it should be at 4.0 release. |
TranceLove
force-pushed
the
bugfix/942
branch
2 times, most recently
from
7a8302c to
e517896
Compare
When the option is "None on top", I think there should be no file and/or folder header labels displayed. Fixes TeamAmaze#942.
TranceLove
force-pushed
the
bugfix/942
branch
from
e517896 to
0df7808
Compare
VishalNehra
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the option is "None on top", I think there should be no file and/or folder header labels displayed.
Issue tracker
Fixes #942
Manual tests
Device: Pixel 6 emulator running Android 13
Folder and Files on Top options should continue to work
While None on Top option will simply sort the files and folders together.
Build tasks success
Successfully running following tasks on local:
./gradlew assembledebug./gradlew spotlessCheck