Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ClassCastException at SmbSearchDialog with SMB SubnetScanner #3954

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Fix ClassCastException at SmbSearchDialog with SMB SubnetScanner #3954

merged 1 commit into from
Oct 30, 2023

Conversation

TranceLove
Copy link
Collaborator

OK, I too think it should have been fixed somewhere else, but now I got one... whatever.

Description

Icon should be androidx.appcompat.widget.AppCompatImageView instead.

Issue tracker

Manual tests

  • Done

  • Device: Pixel 7 emulator

  • OS: Android 14
    SMB search dialog should not crash with ClassCastException error when opening.

Build tasks success

Successfully running following tasks on local:

  • ./gradlew assembledebug
  • ./gradlew spotlessCheck

@TranceLove
Fix ClassCastException at SmbSearchDialog with SMB SubnetScanner
470c15e 
Icon should be androidx.appcompat.widget.AppCompatImageView instead
@TranceLove TranceLove self-assigned this Oct 15, 2023
@TranceLove TranceLove added Issue-Bug Related unexpected behavior or something worth investigating. Area-SMB Related to SMB connections. labels Oct 15, 2023
@TranceLove TranceLove added this to the v4.0 milestone Oct 15, 2023
VishnuSanal
VishnuSanal reviewed Oct 15, 2023
View reviewed changes
Copy link
Member

@VishnuSanal VishnuSanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#3885 is a StringIndexOutOfBoundsException, not ClassCastException 🤔

@TranceLove
Copy link
Collaborator Author

#3885 is a StringIndexOutOfBoundsException, not ClassCastException 🤔

Awch. I thought I tagged the other PR there... this PR is not related to any reported issues - just found a crash as I walked through #3885 though.

@VishnuSanal VishnuSanal added the not-yet-rolled An issue detected on a feature after it is implemented but before it is rolled. label Oct 15, 2023
@VishalNehra VishalNehra merged commit 0a20267 into release/4.0 Oct 30, 2023
4 checks passed
@VishalNehra VishalNehra deleted the bugfix/smb-search-dialog-wrong-class branch October 30, 2023 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VishnuSanal VishnuSanal VishnuSanal left review comments

@VishalNehra VishalNehra VishalNehra approved these changes

@EmmanuelMess EmmanuelMess Awaiting requested review from EmmanuelMess

Assignees

@TranceLove TranceLove

Labels
Area-SMB Related to SMB connections. Issue-Bug Related unexpected behavior or something worth investigating. not-yet-rolled An issue detected on a feature after it is implemented but before it is rolled.
Projects
None yet
Milestone
v3.9
Development

Successfully merging this pull request may close these issues.
3 participants
@TranceLove @VishalNehra @VishnuSanal