Force return IPv4 address when probing network interface for listening address #3946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TranceLove
added
Issue-Bug
|
build test apk |
VishnuSanal
reviewed
Oct 1, 2023
| @@ -115,7 +116,8 @@ object NetworkUtil { | |||
| netinterface.inetAddresses.iterator().forEach { address -> | |||
| // this is the condition that sometimes gives problems | |||
| if (!address.isLoopbackAddress && | |||
| !address.isLinkLocalAddress | |||
| !address.isLinkLocalAddress && | |||
| address is Inet4Address | |||
There was a problem hiding this comment.
this is just a type check, right? does this "force" Ipv4 address? 🤔 I'll send the APK to the reporter & ask them to check.
|
The requested APKs has been built. Please find them from the artifacts section of this PR. |
VishnuSanal
approved these changes
Oct 21, 2023
VishalNehra
approved these changes
Oct 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NetworkUtil.getLocalInetAddress()didn't filter non-IPv4 address during probing, which may returns IPv6 address if the device/network supports. This can be inconvenient to some users running Amaze's FTP server. This PR fixes by filtering to return only when theInetAddressis anInet4Address.Issue tracker
Fixes #3928
Build tasks success
Successfully running following tasks on local:
./gradlew assembledebug./gradlew spotlessCheck