Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Conventions] when make new feature , Naming conventions #1

Open
IGhost-P opened this issue Mar 24, 2022 · 3 comments
Open

[Conventions] when make new feature , Naming conventions #1

IGhost-P opened this issue Mar 24, 2022 · 3 comments
Assignees
@IGhost-P
Labels
documentation Improvements or additions to documentation

Comments

@IGhost-P
Copy link
Member

기능을 추가할때 해야하는 규칙

feature+이름 initial + 이슈를 만든 day + 반복되는 수
예시) 3월 24일 오후 2시에 알람 추가 기능을 만들기 시작함

  1. 해당 기능을 만들기 위해 필요한 조건을 명시한 issues를 만들기 => issues title : [featureSW24] 알람추가 기능
  • 만약 24일에 기능을 하나 더 추가하면 뒤에
  1. branch와 issues 이름을 featureSW24-2으로 만들것

pull requests를 만들면 채팅방에 알려줄것
@IGhost-P IGhost-P assigned IGhost-P and HY219 and unassigned IGhost-P and HY219 Mar 24, 2022
@IGhost-P IGhost-P added the documentation Improvements or additions to documentation label Mar 24, 2022
@Yummy-sk
Copy link
Member

브랜치 이름이 조금 복잡해서 종종 실수를 할 수 있지 않을까여?

개인적으로는 feature/기능명 또는 feature/이름/기능명 정도로도 충분하다고 생각됩니다.

위와 같이 하신 이유가 있으실까요?

@IGhost-P
Copy link
Member Author

숫자로 해야 issues 트래킹을 할때 편하다고 해서 그렇습니다!
기능이 많지 않으니 이름/기능명으로 해도 괜찮을것 같네요

@IGhost-P
Copy link
Member Author

IGhost-P commented Apr 7, 2022

Mondey Updata 용 review

@Yummy-sk Yummy-sk reopened this Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IGhost-P IGhost-P

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Yummy-sk @IGhost-P @HY219