Shifted sequences #122
Open
Shifted sequences #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borisfaure
force-pushed
the
shifted_seq
branch
from
1b0f074 to
62f68cc
Compare
Univa
added a commit
to Univa/rumcake
that referenced
this pull request
Dec 14, 2023
this omits the filter and restore events from the original PR (didn't feel it was necessary): TeXitoi/keyberon#122
borisfaure
force-pushed
the
shifted_seq
branch
from
62f68cc to
3085894
Compare
whereby multiple key events are executed in succession.
and make it only use 2 pointers
(cherry picked from commit 30343989a9f3f40c4cefd5175661e6c5a1c8477b)
borisfaure
force-pushed
the
shifted_seq
branch
from
5f94202 to
b95e064
Compare
This can occur when 2 Press/Release attached to an HoldTap action are handled between 2 ticks. ``` ERROR panicked at /home/boris/stuff/kb/keyberon/src/layout.rs:319:32: attempt to subtract with overflow ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set of commits aims at following up on the work done by @riskable on #30 : some simplifications, a bug is fixed (when using Tap) and some documentation.
This contains work from #117 .
The main addition is to be able to filter (and later restore) some key states: main example is to release Shift for some part of the sequence. I use this a lot to type in french when I use XCompose:
RAlt+^+eto typeê. To be able to use the same action when shift is pressed, I added this filter/restore mechanism in the last commit.