Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mod] rename stack to queue #104

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[mod] rename stack to queue #104

wants to merge 3 commits into from

Conversation

dariogoetz
Copy link
Contributor

This addresses #103 and renames the occurring stacks to queue.

Two things that might require discussion:

  1. The name of the method unstack does not make sense anymore. The corresponding queue version pop is too weak in my opinion. I now named it resolve_queued_event, which is rather long. Do you have a good idea for a name?
  2. There are some occurrences where a closure of a now Queued object is called s (coming from the name Stacked). Shall these be renamed? To q for Queued? Or e for a generic "event"?

@dariogoetz dariogoetz mentioned this pull request Oct 28, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dariogoetz