-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shifted keys leak modifiers #135
Comments
I have a working PoC with #136, but I'm happy to close that and implement anothe approach if it doesn't fit the design of the library. |
I'm in vacations. I'll try to review this next week. If you don't have any sign of me in 2 weeks, don't hesitate to ping me. I've seen this problem recently. I was thinking of.an action that will release in case of another press. You can then use it with MultipleActions. |
No worries, enjoy your vacation! I'll also try your approach in the meantime, thanks. |
@TeXitoi friendly ping 🙂 I tried to see how to implement your suggestion, but I couldn't make sense of it. As far as I can see, when a key is pressed, the other currently pressed keys do not get "notified" such that they could react by releasing themselves, right? Or did I misunderstand your suggestion? (btw. I also opened a PR on keyberon-f4 a while ago, in case you missed it) |
When a sequence like
&[
is rolled, the shift modifier associated with&
is also applied to[
, resulting in the string&{
.I'm looking into fixing this myself, but I wanted to document the problem anyway. Let me know if you have ideas about how to fix this in a way that aligns well with the design of the library.
The text was updated successfully, but these errors were encountered: