Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple tarcaps support #2905

Open
JakubFornadel opened this issue Dec 3, 2024 · 0 comments
Open

Fix multiple tarcaps support #2905

JakubFornadel opened this issue Dec 3, 2024 · 0 comments
Assignees
Labels
task A small task that is, most likely, part of an Epic

Comments

@JakubFornadel
Copy link
Collaborator

Task Description

When downcasing from base to derived packet handlers, we need to differentiate between different tarcap versions...

  if (version_ = TARAXA_NET_VERSION) {
    auto status_packet_handler = packets_handlers_->getSpecificHandler<StatusPacketHandler>();
    status_packet_handler->sendStatus(node_id, true);
  } else {
    auto status_packet_handler = packets_handlers_->getSpecificHandler<v4::StatusPacketHandler>();
    status_packet_handler->sendStatus(node_id, true);
  }

Refactor this so we downcast to a common::StatusPacketHandler base class

Epic Parent

@JakubFornadel JakubFornadel added the task A small task that is, most likely, part of an Epic label Dec 3, 2024
@JakubFornadel JakubFornadel self-assigned this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task A small task that is, most likely, part of an Epic
Projects
None yet
Development

No branches or pull requests

1 participant