Issue 2261/json config overridable cli #2325
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakubFornadel
force-pushed
the
issue-2261/json-config-overridable-cli
branch
from
827c6b1 to
e9a0eaa
Compare
|
@rjonczy I did adjust some of the cli options names so some scripts of yours might not work after we merge this. Is it possible maybe to check somewhere what cli arguments are you calling taraxa binary ? |
…config object from options
JakubFornadel
force-pushed
the
issue-2261/json-config-overridable-cli
branch
from
e9a0eaa to
76bd024
Compare
JakubFornadel
force-pushed
the
issue-2261/json-config-overridable-cli
branch
from
76bd024 to
094e600
Compare
@JakubFornadel sorry, I missed that mention. I just brieflt checked, but it requires more of attention. Will go over this tomorrow morning. |
MatusKysel
reviewed
Feb 23, 2023
| @@ -4,14 +4,17 @@ | |||
| "final_chain_cache_in_blocks": 5, | |||
| "network": { | |||
| "rpc": { | |||
| "enabled": true, | |||
There was a problem hiding this comment.
I do not know about this, e.g. geth as this disabled by default
There was a problem hiding this comment.
will change it to false
MatusKysel
approved these changes
Feb 23, 2023
mfrankovi
approved these changes
Feb 27, 2023
kstdl
approved these changes
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
All config params can be now specified in both json config file as well as command line arguments, e.g.:
can be also specified by:
--data_path=/different/path --network.rpc.enabled=false --network.rpc.http_port=9999If some config parameters are specified in both json config file as well as command line argument, command line argument has higher priority.
This can be now used by https://github.com/Taraxa-project/gitops-ledger to override basically any config parameter by command line argument, restart nodes and override their configs. Before we would have to do it manually somehow 1 by 1 or build a new image, now it is possible to do it in few seconds...
How does the solution address the problem
Changes made