Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overview - Upgrade to new editor #8

Open
1 of 5 tasks
eliot-akira opened this issue Dec 16, 2023 · 2 comments
Open
1 of 5 tasks

Overview - Upgrade to new editor #8

eliot-akira opened this issue Dec 16, 2023 · 2 comments

Comments

@eliot-akira
Copy link
Contributor

eliot-akira commented Dec 16, 2023

This is an overview of tasks related to the recent upgrade of the code editor.

Formatter

Builder integrations

Improvements


About the upgrade from CodeMirror 5 to 6

New editor

Documentation for the new editor: https://docs.loopsandlogic.com/reference/template-system/editor/

The new editor based on CodeMirror 6 is enabled by default in the template post type edit screen (Template, Style, Script, and Control) and in Gutenberg. However, in the Elementor and Beaver Builder integrations, the old editor is still needed until compatibility issues are resolved.

Old editor

The old editor based on CodeMirror 5 has been archived to its own repository.

Its minified bundle without source maps is still in the Template System, until the new editor fully replaces it: modules/codemirror-5.

@eliot-akira eliot-akira pinned this issue Dec 16, 2023
@eliot-akira eliot-akira changed the title Overview - Editor: Upgrade from CodeMirror 5 to 6 [Overview] Editor: Upgrade from CodeMirror 5 to 6 Dec 16, 2023
@eliot-akira eliot-akira changed the title [Overview] Editor: Upgrade from CodeMirror 5 to 6 [Overview] Editor: Upgrade CodeMirror 5 to 6 Dec 16, 2023
@eliot-akira eliot-akira added this to the CodeMirror 5 to 6 milestone Dec 17, 2023
@eliot-akira eliot-akira changed the title [Overview] Editor: Upgrade CodeMirror 5 to 6 Editor: Upgrade CodeMirror 5 to 6 Dec 17, 2023
@eliot-akira eliot-akira changed the title Editor: Upgrade CodeMirror 5 to 6 Overview - Editor: CodeMirror 6 Jan 26, 2024
@eliot-akira eliot-akira changed the title Overview - Editor: CodeMirror 6 Overview - Upgrade to new editor Jan 26, 2024
@eliot-akira eliot-akira moved this to Think in Editor Jan 26, 2024
@eliot-akira eliot-akira moved this from Think to Doing in Editor Jan 30, 2024
@studioavanti
Copy link

studioavanti commented Feb 11, 2024

Hi,

When using the Tangible module to edit a L&L Template directly in a Beaver Builder layout, there's a styling conflict impacting the module's readability.
Beneath the editor, the Settings part is in dark mode with all text dark as well.

This is the L&L CSS rule involved and how i fixed it by modifying the selector:

.fl-lightbox .tangible-template-system--editor-actions-panel * {
    color: #fff;
}

…instead of just:

.tangible-template-system--editor-actions-panel {
    color: #fff;
}

…which is overwritten by a BB rule.

CleanShot 2024-02-11 at 18 27 25

@eliot-akira
Copy link
Contributor Author

Thank you @studioavanti. As you discovered, there's a known issue with Beaver Builder's overly-eager CSS rules causing conflict with the new code editor. I appreciate the suggested fix, I'll try that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Doing
Development

No branches or pull requests

2 participants