Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hangman warnings during check #6

Open
Dasonk opened this issue Jun 25, 2013 · 1 comment
Open

hangman warnings during check #6

Dasonk opened this issue Jun 25, 2013 · 1 comment

Comments

@Dasonk
Copy link
Member

Dasonk commented Jun 25, 2013

File 'tsgames/R/hangman.R':
  assign(".hangmanoptions", c(wins = 0, losses = 0), envir = .GlobalEnv)
  assign(".hangmanoptions", .hangmanoptions + c(1, 0), envir = .GlobalEnv)
  assign(".hangmanoptions", .hangmanoptions + c(0, 1), envir = .GlobalEnv)
* checking Rd files ... OK
* checking Rd metadata ... OK
* checking Rd cross-references ... OK
* checking for missing documentation entries ... WARNING
Undocumented code objects:
  'DICTIONARY'
Undocumented data sets:
  'DICTIONARY'

There are some warnings due to hangman. The DICTIONARY warning should be easy enough to correct. I think we could get around the other warnings about writing to .GlobalEnv by defining an environment for hangmanoptions and using that instead of the global environment.

@trinker
Copy link
Member

trinker commented Jun 26, 2013

I get the following notes that need to be addressed in scoRched and hangman. Not sure how to approach. In the past if you set the variable to NULL first this fixes this problem but here it's defined int he global environment. This is likely what Dason means by define a new environment:

* checking R code for possible problems ... NOTE
.AIanishot: no visible binding for global variable 'x'
.anishot: no visible binding for global variable 'x'
.rungame: no visible binding for global variable 'x'
hangman: no visible binding for global variable '.hangmanoptions'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants