Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dictionary in hangman #4

Open
Dasonk opened this issue Jun 22, 2013 · 1 comment
Open

Dictionary in hangman #4

Dasonk opened this issue Jun 22, 2013 · 1 comment
Assignees

Comments

@Dasonk
Copy link
Member

Dasonk commented Jun 22, 2013

Is the syllables column in the DICTIONARY necessary for hangman? I'm guessing you grabbed it from qdap so that's what that's in there but it seems to just add some unnecessary size to the package. We could probably reduce the dictionary down to a simple vector. And while we're at it maybe prune down the dictionary? I'm not sure mmhmm and hmph are proper hangman words.

@ghost ghost assigned trinker Jun 22, 2013
@trinker
Copy link
Member

trinker commented Jun 26, 2013

I reduced the DIctionary to a single column but am pretty lazy at the moment to fix it to a vector as the code in the hangman function expects a dataframe I believe. I have a big conference this week so maybe later. Technically mmhmm and hmph are interjections and thus considered words, but feel free to prune at will. It's roughly 20000 words so some hand parsing would take some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants