Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add assignment field to CurrencyCode #61

Open
pjfanning opened this issue Sep 9, 2019 · 2 comments
Open

add assignment field to CurrencyCode #61

pjfanning opened this issue Sep 9, 2019 · 2 comments

Comments

@pjfanning
Copy link
Contributor

The assignment field on CountryCode is useful for working out if country codes are no longer used (eg just use the OFFICIALLY_ASSIGNED codes).

CurrencyCode has some javadoc @deprecated markers but I think it would be better to have some explicit flag that can be checked in code.
@pjfanning
Copy link
Contributor Author

@TakahikoKawasaki if this sounds like a good approach, I can do an Pull Request.

@woutb
Copy link

woutb commented May 21, 2021

I've created a pull request for it: #82
Test18 contains an example of how to filter based on the @deprecated annotation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pjfanning @woutb