Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Single Control Set for Audio/Video Files #684

Open
3 tasks done
csponge opened this issue Jan 5, 2025 · 3 comments
Open
3 tasks done

[Feature Request]: Single Control Set for Audio/Video Files #684

csponge opened this issue Jan 5, 2025 · 3 comments
Labels
Priority: Medium An issue that shouldn't be be saved for last Type: Enhancement New feature or request Type: QoL A quality of life (QoL) enhancement or suggestion Type: UI/UX User interface and/or user experience
Milestone

Comments

@csponge
Copy link
Contributor

csponge commented Jan 5, 2025

Checklist

  • I am using an up-to-date version.
  • I have read the documentation.
  • I have searched existing issues.

Description

Some work has been done for playing audio and video files. In the current source, the audio player is using different controls than the video player. It would be nice if they could share the same control set.

Solution

I think one possible solution is to create a separate "media controls" widget that can overlay the video/thumbnail. I've been playing around with it, and I think it could look something like this:

FLAC file:
Screenshot_20250105_143139

It would look similar for a video:

MP4 file:
Screenshot_20250105_143848-1

Alternatives

Another alternative I had considered is to make an all encompassing widget which would contain all the preview widgets and the overlay. I originally wasn't a fan of this approach because it seemed like a large refactor.

I'd be interested in hearing other alternatives.

@csponge csponge added the Type: Enhancement New feature or request label Jan 5, 2025
@Qronikarz
Copy link
Contributor

Qronikarz commented Jan 5, 2025

Don't know how that is exactly handled in TagStudio (so Python and it's libraries), but for example in HTML the <audio> and <video> tags are nearly the same. Only difference is not having the poster width and height. But if I remember correctly you can even play audio in video tag (and vice versa?).

So this idea definitely has value on paper.

@CyanVoxel CyanVoxel added Type: QoL A quality of life (QoL) enhancement or suggestion Type: UI/UX User interface and/or user experience Priority: Medium An issue that shouldn't be be saved for last labels Jan 6, 2025
@CyanVoxel CyanVoxel moved this to 🛠 Ready for Development in TagStudio Development Jan 6, 2025
@CyanVoxel CyanVoxel added the Status: Blocked This issue or pull request is awaiting the outcome of another issue or pull request label Jan 6, 2025
@CyanVoxel
Copy link
Member

I would also love to have a unified widget + controls for video and audio files! This was something mentioned during #576, but fell out of the scope of refactoring the video player in the same PR.

I'm also currently working on a preview panel refactor as a part of #655, which while it doesn't include unified controls, will significantly change the codebase in this area and prepare it for a future unified media widget. Because of this I'll be adding the "Status: Blocked" label to this issue until #655 is merged so that nobody gets caught up in merge conflicts, but otherwise this would be great!

@CyanVoxel CyanVoxel moved this from 🛠 Ready for Development to 🍀 Backlog in TagStudio Development Jan 6, 2025
@CyanVoxel CyanVoxel removed the Status: Blocked This issue or pull request is awaiting the outcome of another issue or pull request label Jan 26, 2025
@CyanVoxel CyanVoxel moved this from 🍀 Backlog to 🛠 Ready for Development in TagStudio Development Jan 26, 2025
@CyanVoxel CyanVoxel added this to the Alpha v9.6 milestone Jan 26, 2025
@CyanVoxel CyanVoxel pinned this issue Jan 29, 2025
@csponge
Copy link
Contributor Author

csponge commented Jan 30, 2025

Just saw this was unblocked. Is anyone already working on this? If not, I'd be happy to help out.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium An issue that shouldn't be be saved for last Type: Enhancement New feature or request Type: QoL A quality of life (QoL) enhancement or suggestion Type: UI/UX User interface and/or user experience
Projects
Status: 🛠 Ready for Development
Development

No branches or pull requests

3 participants