Update certificado.py #335
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caso certificado seja binário (esteja já carregado em memória (ex.: salvo em bin numa base de dados), ler direto do binario caso contrário (é uma string) mantem a leitura do arquivo
felps-dev
reviewed
Apr 20, 2024
Comment on lines
+49
to
+60
| try: | ||
| with open(self.caminho_arquivo, "rb") as cert_arquivo: | ||
| cert_conteudo = cert_arquivo.read() | ||
| except (PermissionError, FileNotFoundError) as exc: | ||
| raise Exception( | ||
| """Falha ao abrir arquivo do certificado digital A1. | ||
| Verifique local e permissoes do arquivo.""" | ||
| ) from exc | ||
| except Exception as exc: | ||
| raise Exception( | ||
| "Falha ao abrir arquivo do certificado digital A1. Causa desconhecida." | ||
| ) from exc |
There was a problem hiding this comment.
Creio que esse try precise ficar antes do if, todo o carregamento precisa ter o try-catch.
leotada
requested changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Este pull request visa otimizar o load do certificado. Agora, o código irá verificar se a variavel recebida já está carregada em memória em formato binário, como quando armazenado diretamente em um campo binario de um banco de dados.
Se o certificado estiver nesse formato, o código fará a leitura diretamente do binário.
Caso contrário (se o certificado for fornecido como uma string), o código manterá a leitura de um arquivo.