[TASK] Adjust mount point indexing #4195
Conversation
|
Test Reason is probably a bug in |
dkd-friedrich
force-pushed
the
bugfix/main/4160-fix_mountpage_indexing_and_tests
branch
from
ea65d7e
to
08e5ff0
Compare
| Adjust mount point indexing | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| Mount point indexing and corresponding tests have been adjusted for TYPO3 13. Mount points are supported in general and the mounted pages will be indexed like standard pages. | ||
|
|
||
| But there are some points to consider: | ||
|
|
||
| * Cross-site mounts require that `config.index_enable = 1` is set in the pagetree of the mounted page, as TYPO3 loads the TypoScript of the mounted page | ||
| * Mounted pages from a pagetree without a site configuration cannot be indexed, in fact TYPO3 currently can't mount a page from a page tree without a site configuration and an exeception occurs | ||
|
|
There was a problem hiding this comment.
Double pasted the copy?
There was a problem hiding this comment.
Right, will remove the duplicate
| * |—[14] Mount Point (to [24] to show contents from) | ||
| */ | ||
| #[Test] | ||
| public function canIndexCrossSiteMountsWithoutSiteConfiguration(): void |
There was a problem hiding this comment.
Is that scenario possible in TYPO3 Backend at all?
As far as I know, TYPO3 creates a site-config.yaml file as soon the page is marked as root.
Can that test-case be removed?
There was a problem hiding this comment.
This is the original test using a sysfolder with pages that should be mounted (no site root), but currently TYPO3 cannot mount such pages and an exception occurs:
(1/1) #1521716622 TYPO3\CMS\Core\Exception\SiteNotFoundException
No site found in root line of page 86
This issue already exists in TYPO3 12, I am currently not sure why this test worked in TYPO3 12, test results in v12 might be misleading.
As it's not a valid and supported scenario in the TYPO3 core, we could IMHO delete the test.
There was a problem hiding this comment.
OK,
I guess in TYPO3 12 it is/was still possible to use old data(created in Versions prior 12 or 11 LTS).
Yes, I've created an issue and prepared a patch, see https://forge.typo3.org/issues/105376 |
|
I am postponing work on this problem until we receive feedback in https://forge.typo3.org/issues/105376. Our further action depends on whether the patch is adopted. |
Fixtures of ConnectionManagerTest were not yet updated and included basic configuration that can be provided automatically, this commit cleans the fixtures and enables the automatic provision.
Mount point indexing and corresponding tests have been adjusted for
TYPO3 13. Mount points are supported in general and the mounted pages
will be indexed like standard pages.
But there are some points to consider:
* Cross-site mounts require that `config.index_enable = 1` is set
in the pagetree of the mounted page, as TYPO3 loads the
TypoScript of the mounted page.
This is probably a bug in the TYPO3 core and may change, due to
changes in RootlineUtility->generateRootlineCache() the mount page
pid isn't used any more.
* Pages in a pagetree without a site configuration cannot be
indexed, in fact TYPO3 currently can't mount a page from a page
tree without a site configuration and an exeception occurs.
Test procedure in PageIndexerTest has been improved and now uses
the PageUriBuilder to build the url to index, instead of building
the url in the test itself.
Resolves: TYPO3-Solr#4160
dkd-kaehm
force-pushed
the
bugfix/main/4160-fix_mountpage_indexing_and_tests
branch
from
08e5ff0
to
de98a93
Compare
Mount point indexing and corresponding tests have been adjusted for
TYPO3 13. Mount points are supported in general and the mounted pages
will be indexed like standard pages.
But there are some points to consider:
config.index_enable = 1is setin the pagetree of the mounted page, as TYPO3 loads the
TypoScript of the mounted page.
This is probably a bug in the TYPO3 core and may change, due to
changes in RootlineUtility->generateRootlineCache() the mount page
pid isn't used any more.
indexed, in fact TYPO3 currently can't mount a page from a page
tree without a site configuration and an exeception occurs.
Test procedure in PageIndexerTest has been improved and now uses
the PageUriBuilder to build the url to index, instead of building
the url in the test itself.
Resolves: #4160