Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Install.rst - 'docroot' MUST be 'public' #187

Closed
wants to merge 17 commits into from

Conversation

linawolf and others added 17 commits October 3, 2021 15:26
* [TASK] add log path for composer-based installs

* Update TYPO3.rst

Co-authored-by: Tom Warwick <[email protected]>
In order to work with TYPO3 11.5, rewrite rules for files within /typo3 needs to be configured.
Otherwise the backend is never accessible.

See: https://github.com/drud/ddev/blob/a1b9ee4f8e8e2c6bb04b3a9e93e361c2040e8477/pkg/ddevapp/webserver_config_assets/nginx-site-typo3.conf#L31
This commit adds the missing user management guide
Also clarify that TYPO3 11 requires Composer 2.1.0
To further improve consistency in the TYPO3 documentation, the same top-level domain should be used in all places. It is proposed to use

1. https://example.org
2. https://example.com
3. https://example.net

in that order and

4. https://example.local

for explicit local development context.
Use `<placeholder>` as default placeholder style in
URLs since it's standard in Backus–Naur form.

To avoid URL linking, apply the reST directive `:samp:`.
* [SECURITY] Add information for logging

Recommend using logging severity including WARNING or higher
for production.

Related: TYPO3-Documentation/TYPO3CMS-Reference-CoreApi#351

* Update DeployTYPO3.rst

* Update DeployTYPO3.rst

Co-authored-by: Tom Warwick <[email protected]>
Add recommendation for using HTTPS in production

Related: TYPO3-Documentation/TYPO3CMS-Reference-CoreApi:#351

Co-authored-by: Tom Warwick <[email protected]>
People should know that they can't use a different value for 'docroot'. 
See also:
* TYPO3/get.typo3.org#291
* TYPO3/TYPO3.CMS.BaseDistribution#54
* ddev/ddev#3701
Copy link
Member

@linawolf linawolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make changes on main and lets backport them into 11.5

@@ -54,6 +54,7 @@ Execute Composer Create-Project
cd example-project-directory

# Tell DDEV to create a new project of type "typo3"
# 'docroot' MUST be 'public'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would never use must without an explaination.

@marble marble changed the base branch from 11.5 to main March 22, 2022 15:28
@marble marble changed the base branch from main to 11.5 March 22, 2022 16:13
@marble marble changed the base branch from 11.5 to main March 22, 2022 16:40
@marble
Copy link
Member Author

marble commented Mar 22, 2022

I'll create a correct PR again - don't know how to fix this one.

@marble marble closed this Mar 22, 2022
@marble marble deleted the marble-docroot-must-be-public branch March 22, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants