Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linreg scaling when R<0 #312

Open
wpreimes opened this issue Nov 25, 2024 · 0 comments
Open

linreg scaling when R<0 #312

wpreimes opened this issue Nov 25, 2024 · 0 comments

Comments

@wpreimes
Copy link
Member

wpreimes commented Nov 25, 2024

I think the linreg scaling should not be applied to data where R is negative? Currently we use abs(slope), but I don't think that is the solution to the problem (it might be the best compromise if we always want to return something, even if it's not scaled properly). Maybe rather we should return NaN when slope < 0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant