Skip to content
This repository has been archived by the owner on Jan 10, 2024. It is now read-only.

open nav.tum.sexy to show location #1443

Merged
merged 9 commits into from
Jun 1, 2022

Conversation

kmodexc
Copy link
Contributor

@kmodexc kmodexc commented May 12, 2022

Issue

This fixes the following issue(s):

This only opens nav.tum.sexy and does not have an in-app map. However i think that ok for now and solves the issue for me.

On step for #1437

@joschahenningsen
Copy link
Member

As long as the in app roomfinder does not work this seems to be a reasonable way to go 👌
@CommanderStorm are you fine with this? Will the API URL this way?

@CommanderStorm
Copy link
Member

CommanderStorm commented May 12, 2022

Yes this works with us. We have changed the URLs last week to accommodate this feature.
We should however not keep this as a permanent fix (which should also be obvious)

@kmodexc is working on that too, so I see no problem in merging this

@kordianbruck
Copy link
Member

I'd probably recommend to instead do this in an in-app webview instead of opening an external browser: https://developer.android.com/guide/webapps/webview

@kmodexc
Copy link
Contributor Author

kmodexc commented May 12, 2022

@kordianbruck Good idea. i will do this

Copy link
Member

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont have a strong oppinion on these suggestions. These are suggestions, not demands.

kmodexc and others added 4 commits May 16, 2022 17:54
Co-authored-by: Frank Elsinga <[email protected]>
Co-authored-by: Frank Elsinga <[email protected]>
Co-authored-by: Frank Elsinga <[email protected]>
@kmodexc
Copy link
Contributor Author

kmodexc commented May 16, 2022

@CommanderStorm Was a good idea. Hopefully this is consistent with the notation in other places.

@kmodexc kmodexc requested a review from CommanderStorm May 17, 2022 14:06
@kmodexc
Copy link
Contributor Author

kmodexc commented May 17, 2022

@kordianbruck can you review this?

Copy link
Member

@joschahenningsen joschahenningsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Happy to work on #1451 if no one picked it up already :)

@joschahenningsen joschahenningsen merged commit c5fd390 into TUM-Dev:master Jun 1, 2022
@CommanderStorm CommanderStorm added the Roomfinder Related to the the Romfinder label Jun 6, 2022
tobiasjungmann pushed a commit that referenced this pull request Jan 13, 2023
* open nav.tum.sexy to show location

* calender detail call navigatumactivity

* add NavigatumActivity to manifest

* create NavigatumActivity

* remove unused import

* change namestyle

Co-authored-by: Frank Elsinga <[email protected]>

* change namestyle

Co-authored-by: Frank Elsinga <[email protected]>

* change namestyle

Co-authored-by: Frank Elsinga <[email protected]>

Co-authored-by: Frank Elsinga <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Roomfinder Related to the the Romfinder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants