Skip to content
This repository has been archived by the owner on Jan 10, 2024. It is now read-only.

Migrate the Roomfinder to NavigaTUM #1451

Closed
CommanderStorm opened this issue May 26, 2022 · 2 comments · Fixed by #1462
Closed

Migrate the Roomfinder to NavigaTUM #1451

CommanderStorm opened this issue May 26, 2022 · 2 comments · Fixed by #1462
Assignees
Labels
Roomfinder Related to the the Romfinder

Comments

@CommanderStorm
Copy link
Member

Currently the used roomfinder has a few problems. Namely #1338, #1337, #1182 and #415
A migration to NavigaTUM could solve some of these problems.

The suggested plan to fix this would be:

  1. reviewing and merging open nav.tum.sexy to show location #1443 to have an intermediate fix
  2. solving [Feature] Use OpenStreetMaps for Roomfinder #1437, to get a map to display coordinates
  3. implementing the more information nav.tum.sexy/api/get/:id api-endpint (replacing the current endpoit)
  4. implementing the search nav.tum.sexy/api/search?q=querry api-endpoint (replacing the current endpoit)

Optional:
5. implement the feedback api

All of these steps require the previous step to be completed, to work to the full extend possible, but dont require any of the further steps to be completed to be shipped (except, that once 3 is done, 1. will become unnessesary and we may want to remove this code).
We have renamed some rooms in the roomfinder, but those are edgecases, that I assume most of our users will not notice.

You can find our api documentation at https://editor.swagger.io/?url=https://raw.githubusercontent.com/TUM-Dev/navigatum/main/openapi.yaml
If you find any dificultys/anything is unclear/you found a bug, please feel free to open an issue.

@CommanderStorm CommanderStorm changed the title Migrate the Roomfinder to [NavigaTUM](https://github.com/TUM-Dev/navigatum) Migrate the Roomfinder to NavigaTUM May 26, 2022
@CommanderStorm CommanderStorm added the Roomfinder Related to the the Romfinder label Jun 6, 2022
@PiotrKedra
Copy link
Contributor

Anybody is working on this currently? I would like to work on points 3 and 4 (replacing the current endpoints with navigatum)

@CommanderStorm
Copy link
Member Author

Sorry for the long delay:
@kmodexc is working on #1437, but this will take a bit longer, since we are currently in the middle of the semester and stuff is a bit stressful currently. #1437 is a bigger issue than initial anticipated 😉

Help with 3,4 would be greatly appreciated. ❤️

There are two stopgap solutions until #1437 is properly done I can imagine (one is more work, one is less), since until then we won't have an interactive map.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Roomfinder Related to the the Romfinder
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants