From 3b122b0266dfc146e363382600af7c6c7488b559 Mon Sep 17 00:00:00 2001 From: Jean-Marie Gervais Date: Tue, 3 Sep 2024 17:17:12 +0200 Subject: [PATCH] fix: ansible.builtin.copy dest should specify full filename --- roles/exporter/jmx/tasks/install.yml | 2 +- roles/hadoop/common/tasks/install.yml | 2 +- roles/hbase/common/tasks/install_hbase.yml | 2 +- roles/hbase/common/tasks/install_phoenix.yml | 2 +- roles/hbase/phoenix/queryserver/common/tasks/install.yml | 2 +- roles/hbase/ranger/tasks/install.yml | 2 +- roles/hdfs/ranger/tasks/install.yml | 2 +- roles/hive/common/tasks/hdfs_init.yml | 2 +- roles/hive/common/tasks/install_hive.yml | 4 ++-- roles/hive/ranger/tasks/install.yml | 2 +- roles/knox/common/tasks/install.yml | 8 ++++---- roles/knox/ranger/tasks/install.yml | 2 +- roles/ranger/admin/tasks/install.yml | 2 +- roles/ranger/kms/tasks/install.yml | 2 +- roles/ranger/solr/tasks/install.yml | 4 ++-- roles/ranger/usersync/tasks/install.yml | 2 +- roles/spark/common/tasks/install.yml | 2 +- roles/yarn/ranger/tasks/install.yml | 2 +- roles/zookeeper/common/tasks/install.yml | 2 +- 19 files changed, 24 insertions(+), 24 deletions(-) diff --git a/roles/exporter/jmx/tasks/install.yml b/roles/exporter/jmx/tasks/install.yml index ccb08584..38fc1d01 100644 --- a/roles/exporter/jmx/tasks/install.yml +++ b/roles/exporter/jmx/tasks/install.yml @@ -13,7 +13,7 @@ - name: Upload jmx-exporter jar ansible.builtin.copy: src: "{{ binaries_local_dir }}/{{ jmx_exporter_dist_file }}" - dest: "{{ jmx_exporter_root_dir }}" + dest: "{{ jmx_exporter_root_dir }}/{{ jmx_exporter_dist_file }}" group: root owner: root mode: "644" diff --git a/roles/hadoop/common/tasks/install.yml b/roles/hadoop/common/tasks/install.yml index b0a34782..611bd477 100644 --- a/roles/hadoop/common/tasks/install.yml +++ b/roles/hadoop/common/tasks/install.yml @@ -18,7 +18,7 @@ - name: Upload {{ hadoop_dist_file }} ansible.builtin.copy: src: "{{ binaries_local_dir }}/{{ hadoop_dist_file }}" - dest: "{{ binaries_upload_dir }}" + dest: "{{ binaries_upload_dir }}/{{ hadoop_dist_file }}" group: root owner: root mode: "644" diff --git a/roles/hbase/common/tasks/install_hbase.yml b/roles/hbase/common/tasks/install_hbase.yml index f54292d5..c53e8a26 100644 --- a/roles/hbase/common/tasks/install_hbase.yml +++ b/roles/hbase/common/tasks/install_hbase.yml @@ -12,7 +12,7 @@ - name: Upload {{ hbase_dist_file }} ansible.builtin.copy: src: "{{ binaries_local_dir }}/{{ hbase_dist_file }}" - dest: "{{ binaries_upload_dir }}" + dest: "{{ binaries_upload_dir }}/{{ hbase_dist_file }}" owner: root group: root mode: "644" diff --git a/roles/hbase/common/tasks/install_phoenix.yml b/roles/hbase/common/tasks/install_phoenix.yml index 4a0a92f6..f9e0f988 100644 --- a/roles/hbase/common/tasks/install_phoenix.yml +++ b/roles/hbase/common/tasks/install_phoenix.yml @@ -5,7 +5,7 @@ - name: Upload {{ phoenix_dist_file }} ansible.builtin.copy: src: "{{ binaries_local_dir }}/{{ phoenix_dist_file }}" - dest: "{{ binaries_upload_dir }}" + dest: "{{ binaries_upload_dir }}/{{ phoenix_dist_file }}" owner: root group: root mode: "644" diff --git a/roles/hbase/phoenix/queryserver/common/tasks/install.yml b/roles/hbase/phoenix/queryserver/common/tasks/install.yml index 7cda40e2..6cc68ff1 100644 --- a/roles/hbase/phoenix/queryserver/common/tasks/install.yml +++ b/roles/hbase/phoenix/queryserver/common/tasks/install.yml @@ -12,7 +12,7 @@ - name: Upload {{ phoenix_queryserver_dist_file }} ansible.builtin.copy: src: "{{ binaries_local_dir }}/{{ phoenix_queryserver_dist_file }}" - dest: "{{ binaries_upload_dir }}" + dest: "{{ binaries_upload_dir }}/{{ phoenix_queryserver_dist_file }}" owner: root group: root mode: "644" diff --git a/roles/hbase/ranger/tasks/install.yml b/roles/hbase/ranger/tasks/install.yml index 9340177a..f77c61a1 100644 --- a/roles/hbase/ranger/tasks/install.yml +++ b/roles/hbase/ranger/tasks/install.yml @@ -5,7 +5,7 @@ - name: Upload {{ ranger_hbase_dist_file }} ansible.builtin.copy: src: "{{ binaries_local_dir }}/{{ ranger_hbase_dist_file }}" - dest: "{{ binaries_upload_dir }}" + dest: "{{ binaries_upload_dir }}/{{ ranger_hbase_dist_file }}" owner: root group: root mode: "644" diff --git a/roles/hdfs/ranger/tasks/install.yml b/roles/hdfs/ranger/tasks/install.yml index 1ec9b532..45b567c9 100644 --- a/roles/hdfs/ranger/tasks/install.yml +++ b/roles/hdfs/ranger/tasks/install.yml @@ -5,7 +5,7 @@ - name: Upload {{ ranger_hdfs_dist_file }} ansible.builtin.copy: src: "{{ binaries_local_dir }}/{{ ranger_hdfs_dist_file }}" - dest: "{{ binaries_upload_dir }}" + dest: "{{ binaries_upload_dir }}/{{ ranger_hdfs_dist_file }}" owner: root group: root mode: "644" diff --git a/roles/hive/common/tasks/hdfs_init.yml b/roles/hive/common/tasks/hdfs_init.yml index 1bdb9d0f..3d94feaf 100644 --- a/roles/hive/common/tasks/hdfs_init.yml +++ b/roles/hive/common/tasks/hdfs_init.yml @@ -55,7 +55,7 @@ - name: Upload {{ tez_dist_file }} ansible.builtin.copy: src: "{{ binaries_local_dir }}/{{ tez_dist_file }}" - dest: "{{ binaries_upload_dir }}" + dest: "{{ binaries_upload_dir }}/{{ tez_dist_file }}" owner: root group: root mode: "644" diff --git a/roles/hive/common/tasks/install_hive.yml b/roles/hive/common/tasks/install_hive.yml index 73f8f1be..1bcd1691 100644 --- a/roles/hive/common/tasks/install_hive.yml +++ b/roles/hive/common/tasks/install_hive.yml @@ -5,7 +5,7 @@ - name: Upload {{ hive_dist_file }} ansible.builtin.copy: src: "{{ binaries_local_dir }}/{{ hive_dist_file }}" - dest: "{{ binaries_upload_dir }}" + dest: "{{ binaries_upload_dir }}/{{ hive_dist_file }}" owner: root group: root mode: "644" @@ -70,7 +70,7 @@ - name: Upload {{ tez_dist_file }} ansible.builtin.copy: src: "{{ binaries_local_dir }}/{{ tez_dist_file }}" - dest: "{{ binaries_upload_dir }}" + dest: "{{ binaries_upload_dir }}/{{ tez_dist_file }}" owner: root group: root mode: "644" diff --git a/roles/hive/ranger/tasks/install.yml b/roles/hive/ranger/tasks/install.yml index 44d4ac16..cda9aea8 100644 --- a/roles/hive/ranger/tasks/install.yml +++ b/roles/hive/ranger/tasks/install.yml @@ -5,7 +5,7 @@ - name: Upload {{ ranger_hive_dist_file }} ansible.builtin.copy: src: "{{ binaries_local_dir }}/{{ ranger_hive_dist_file }}" - dest: "{{ binaries_upload_dir }}" + dest: "{{ binaries_upload_dir }}/{{ ranger_hive_dist_file }}" owner: root group: root mode: "644" diff --git a/roles/knox/common/tasks/install.yml b/roles/knox/common/tasks/install.yml index 12b8165f..08cbeaa3 100644 --- a/roles/knox/common/tasks/install.yml +++ b/roles/knox/common/tasks/install.yml @@ -17,14 +17,14 @@ - name: Upload Knox binaries ansible.builtin.copy: - src: "{{ item }}" - dest: "{{ binaries_upload_dir }}" + src: "{{ binaries_local_dir }}/{{ item }}" + dest: "{{ binaries_upload_dir }}/{{ item }}" owner: root group: root mode: "644" loop: - - "{{ binaries_local_dir }}/{{ knox_dist_file }}" - - "{{ binaries_local_dir }}/{{ knoxshell_dist_file }}" + - "{{ knox_dist_file }}" + - "{{ knoxshell_dist_file }}" diff: false - name: Ensure {{ knox_root_dir }} exists diff --git a/roles/knox/ranger/tasks/install.yml b/roles/knox/ranger/tasks/install.yml index 27b17307..b0ae91bf 100644 --- a/roles/knox/ranger/tasks/install.yml +++ b/roles/knox/ranger/tasks/install.yml @@ -5,7 +5,7 @@ - name: Upload {{ ranger_knox_dist_file }} ansible.builtin.copy: src: "{{ binaries_local_dir }}/{{ ranger_knox_dist_file }}" - dest: "{{ binaries_upload_dir }}" + dest: "{{ binaries_upload_dir }}/{{ ranger_knox_dist_file }}" owner: root group: root mode: "644" diff --git a/roles/ranger/admin/tasks/install.yml b/roles/ranger/admin/tasks/install.yml index a6d06983..84e61306 100644 --- a/roles/ranger/admin/tasks/install.yml +++ b/roles/ranger/admin/tasks/install.yml @@ -10,7 +10,7 @@ - name: Upload {{ ranger_dist_file }} ansible.builtin.copy: src: "{{ binaries_local_dir }}/{{ ranger_dist_file }}" - dest: "{{ binaries_upload_dir }}" + dest: "{{ binaries_upload_dir }}/{{ ranger_dist_file }}" owner: root group: root mode: "644" diff --git a/roles/ranger/kms/tasks/install.yml b/roles/ranger/kms/tasks/install.yml index cc266ed6..bf2f4560 100644 --- a/roles/ranger/kms/tasks/install.yml +++ b/roles/ranger/kms/tasks/install.yml @@ -17,7 +17,7 @@ - name: Upload {{ ranger_kms_dist_file }} ansible.builtin.copy: src: "{{ binaries_local_dir }}/{{ ranger_kms_dist_file }}" - dest: "{{ binaries_upload_dir }}" + dest: "{{ binaries_upload_dir }}/{{ ranger_kms_dist_file }}" owner: root group: root mode: "644" diff --git a/roles/ranger/solr/tasks/install.yml b/roles/ranger/solr/tasks/install.yml index 54999eed..7ac82f67 100644 --- a/roles/ranger/solr/tasks/install.yml +++ b/roles/ranger/solr/tasks/install.yml @@ -34,7 +34,7 @@ - name: Upload {{ solr_dist_file }} ansible.builtin.copy: src: "{{ binaries_local_dir }}/{{ solr_dist_file }}" - dest: "{{ binaries_upload_dir }}" + dest: "{{ binaries_upload_dir }}/{{ solr_dist_file }}" owner: root group: root mode: "644" @@ -113,7 +113,7 @@ - name: Upload solr bootstrap configuration files ansible.builtin.copy: src: "{{ item }}" - dest: "{{ solr_bootstrap_config_dir }}" + dest: "{{ solr_bootstrap_config_dir }}/{{ item }}" owner: root group: root mode: "644" diff --git a/roles/ranger/usersync/tasks/install.yml b/roles/ranger/usersync/tasks/install.yml index e7ef49b3..dd82c15b 100644 --- a/roles/ranger/usersync/tasks/install.yml +++ b/roles/ranger/usersync/tasks/install.yml @@ -10,7 +10,7 @@ - name: Upload {{ ranger_usersync_dist_file }} ansible.builtin.copy: src: "{{ binaries_local_dir }}/{{ ranger_usersync_dist_file }}" - dest: "{{ binaries_upload_dir }}" + dest: "{{ binaries_upload_dir }}/{{ ranger_usersync_dist_file }}" owner: root group: root mode: "644" diff --git a/roles/spark/common/tasks/install.yml b/roles/spark/common/tasks/install.yml index 27760345..a092b4b4 100644 --- a/roles/spark/common/tasks/install.yml +++ b/roles/spark/common/tasks/install.yml @@ -5,7 +5,7 @@ - name: Upload {{ spark_dist_file }} ansible.builtin.copy: src: "{{ binaries_local_dir }}/{{ spark_dist_file }}" - dest: "{{ binaries_upload_dir }}" + dest: "{{ binaries_upload_dir }}/{{ spark_dist_file }}" owner: root group: root mode: "644" diff --git a/roles/yarn/ranger/tasks/install.yml b/roles/yarn/ranger/tasks/install.yml index 8db91f5a..a5ec5917 100644 --- a/roles/yarn/ranger/tasks/install.yml +++ b/roles/yarn/ranger/tasks/install.yml @@ -5,7 +5,7 @@ - name: Upload {{ ranger_yarn_dist_file }} ansible.builtin.copy: src: "{{ binaries_local_dir }}/{{ ranger_yarn_dist_file }}" - dest: "{{ binaries_upload_dir }}" + dest: "{{ binaries_upload_dir }}/{{ ranger_yarn_dist_file }}" owner: root group: root mode: "644" diff --git a/roles/zookeeper/common/tasks/install.yml b/roles/zookeeper/common/tasks/install.yml index 7f298040..8bbd333a 100644 --- a/roles/zookeeper/common/tasks/install.yml +++ b/roles/zookeeper/common/tasks/install.yml @@ -18,7 +18,7 @@ - name: Upload {{ zookeeper_dist_file }} ansible.builtin.copy: src: "{{ binaries_local_dir }}/{{ zookeeper_dist_file }}" - dest: "{{ binaries_upload_dir }}" + dest: "{{ binaries_upload_dir }}/{{ zookeeper_dist_file }}" group: root owner: root mode: "644"