From 0f6e2672f08972e5da5acfeb98e3b8a5384ee61a Mon Sep 17 00:00:00 2001
From: GuillaumeHold <guillaume.h@adaltas.com>
Date: Fri, 22 Sep 2023 12:39:14 +0200
Subject: [PATCH] fix: ansible syntax

---
 roles/spark/client/tasks/install.yml | 22 +++++++++++-----------
 roles/spark/common/tasks/install.yml |  3 +--
 2 files changed, 12 insertions(+), 13 deletions(-)

diff --git a/roles/spark/client/tasks/install.yml b/roles/spark/client/tasks/install.yml
index 7f637b9d..9fc4116f 100644
--- a/roles/spark/client/tasks/install.yml
+++ b/roles/spark/client/tasks/install.yml
@@ -3,12 +3,12 @@
 
 ---
 - name: Ensure spark common installation steps are performed
-  import_role:
+  ansible.builtin.import_role:
     name: tosit.tdp.spark.common
     tasks_from: install
 
 - name: Upload spark hbase jar
-  copy:
+  ansible.builtin.copy:
     src: "{{ binaries_local_dir }}/{{ spark_hbase_dist_file }}"
     dest: "{{ spark_root_dir }}/{{ spark_release }}/jars"
     owner: root
@@ -18,7 +18,7 @@
   diff: false
 
 - name: Copy audience-annotations dependency
-  copy:
+  ansible.builtin.copy:
     src: "{{ hbase_install_dir }}/lib/client-facing-thirdparty/audience-annotations-0.5.0.jar"
     dest: "{{ spark_root_dir }}/{{ spark_release }}/jars"
     owner: root
@@ -29,7 +29,7 @@
   diff: false
 
 - name: Create configuration directory
-  file:
+  ansible.builtin.file:
     path: "{{ spark_client_conf_dir }}"
     state: directory
     owner: root
@@ -37,7 +37,7 @@
     mode: "755"
 
 - name: "Render /usr/bin/{{ spark_version }}-submit command"
-  template:
+  ansible.builtin.template:
     src: spark-submit-command.j2
     dest: "/usr/bin/{{ spark_version }}-submit"
     owner: root
@@ -45,7 +45,7 @@
     mode: "755"
 
 - name: "Render /usr/bin/{{ spark_version }}-shell command"
-  template:
+  ansible.builtin.template:
     src: spark-shell-command.j2
     dest: "/usr/bin/{{ spark_version }}-shell"
     owner: root
@@ -53,7 +53,7 @@
     mode: "755"
 
 - name: "Render /usr/bin/{{ spark_version }}-sql command"
-  template:
+  ansible.builtin.template:
     src: spark-sql-command.j2
     dest: "/usr/bin/{{ spark_version }}-sql"
     owner: root
@@ -61,7 +61,7 @@
     mode: "755"
 
 - name: "Render /usr/bin/py{{ spark_version }} command"
-  template:
+  ansible.builtin.template:
     src: pyspark-command.j2
     dest: "/usr/bin/py{{ spark_version }}"
     owner: root
@@ -69,7 +69,7 @@
     mode: "755"
 
 - name: "Render /usr/bin/{{ spark_version }}R-shell command"
-  template:
+  ansible.builtin.template:
     src: sparkr-shell-command.j2
     dest: "/usr/bin/{{ spark_version }}r-shell"
     owner: root
@@ -78,8 +78,8 @@
   when: (spark_version == "spark3") and spark_enable_r
 
 - name: Create symbolic link to R library
-  file:
+  ansible.builtin.file:
     src: "{{ spark_install_dir }}/R/lib/SparkR"
     dest: "/usr/lib64/R/library/SparkR"
     state: link
-  when: (spark_version == "spark3") and spark_enable_r 
\ No newline at end of file
+  when: (spark_version == "spark3") and spark_enable_r
\ No newline at end of file
diff --git a/roles/spark/common/tasks/install.yml b/roles/spark/common/tasks/install.yml
index a0e60ac3..703e95cf 100644
--- a/roles/spark/common/tasks/install.yml
+++ b/roles/spark/common/tasks/install.yml
@@ -56,5 +56,4 @@
     state: directory
     owner: "{{ spark_user }}"
     group: "{{ hadoop_group }}"
-    mode: "750"
-
+    mode: "750"
\ No newline at end of file