Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOM_TNS: Configurable author list #7

Closed
griffin-h opened this issue Dec 14, 2023 · 4 comments · Fixed by #25
Closed

TOM_TNS: Configurable author list #7

griffin-h opened this issue Dec 14, 2023 · 4 comments · Fixed by #25
Labels
User Issue Raised by a user

Comments

@griffin-h
Copy link
Contributor

It would be great to allow for a user-configurable author list in the settings.py file. For example, I would like to make mine something like:

'{user_full_name}, on behalf of SAGUARO'

but I could also imagine the majority of users wanting to substitute a static list of names. You can see the variety of what is done here.

The key would be to allow individual user names to be substituted in somehow, and then pass the formatted string to the forms on tns_extras.py lines 26 and 55. Probably worth considering alongside #4.

@jchate6
Copy link
Contributor

jchate6 commented Dec 15, 2023

It might be worth looking into including this capability as part of tom_publications.

@jchate6 jchate6 moved this from Triage to Backlog in TOM Toolkit Dec 15, 2023
@griffin-h
Copy link
Contributor Author

Sorry, this was completely not clear from my initial issue, but all I'm asking about is the default author list that is prefilled in on the TNS forms. It should be a pretty simple fix of just adding one extra configuration item to the TNS block in settings.py.

@jchate6
Copy link
Contributor

jchate6 commented Dec 15, 2023

@griffin-h yes, I think we understand the immediate use case for the default author list. We probably won't get to it for a few weeks with the holidays and AAS coming up.

The above comment was more for doing this more generally with both tom_tns and other modules.
tom_publications might be an interesting place to house this code (if not tom_base.)
The general idea would be that we could have customization author lists in different contexts that could be stored or generated for different circumstances so each app with an author list wouldn't require a different setting. This was a hasty note made during a meeting as part of a larger discussion about future development.

@jchate6 jchate6 moved this from Backlog to Triage in TOM Toolkit Jan 17, 2024
@jchate6 jchate6 changed the title Configurable author list TOM_TNS: Configurable author list Jan 19, 2024
@jchate6 jchate6 added the User Issue Raised by a user label Jan 22, 2024
@jchate6 jchate6 moved this from Triage to Backlog in TOM Toolkit Jan 23, 2024
@jchate6
Copy link
Contributor

jchate6 commented May 7, 2024

I believe this is completed by PR #25

@jchate6 jchate6 closed this as completed May 7, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Closed in TOM Toolkit May 7, 2024
@jchate6 jchate6 reopened this May 7, 2024
@github-project-automation github-project-automation bot moved this from Closed to Triage in TOM Toolkit May 7, 2024
@jchate6 jchate6 linked a pull request May 7, 2024 that will close this issue
@jchate6 jchate6 moved this from Triage to Backlog in TOM Toolkit May 7, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Closed in TOM Toolkit May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
User Issue Raised by a user
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants