Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tom_Nonlocalizedevents is out of date with Tom_base #37

Open
3 of 9 tasks
jchate6 opened this issue Nov 30, 2023 · 2 comments · Fixed by #36
Open
3 of 9 tasks

Tom_Nonlocalizedevents is out of date with Tom_base #37

jchate6 opened this issue Nov 30, 2023 · 2 comments · Fixed by #36
Assignees
Labels
bug Something isn't working dependencies Pull requests that update a dependency file User Issue Raised by a user

Comments

@jchate6
Copy link
Contributor

jchate6 commented Nov 30, 2023

  • Tests are failing for dependabot PRs.
  • django-filter has incompatible requirements with tom_base.
  • ligo-skymap fails on a python 3.8 installation with the following error:
Incompatible constraints in requirements of oldest-supported-numpy (2022.11.19):
  numpy (==1.22.2) ; platform_machine == "loongarch64" and python_version < "3.11" or python_version == "3.8" and platform_python_implementation == "PyPy"
  numpy (==1.21.0) ; python_version == "3.8" and platform_machine == "arm64" and platform_system == "Darwin"

Here are the transcribed notes from LCOGT/sprint-planning#98

Effort: 2
Created: Oct 14, 2024

Description:

As a tom user, I would like the tom_nonlocalizedevents plugin to be up to date. It hasn't really been developed for over a year, so it is in need of some TLC and updating of libraries as well as some updates for tighter HERMES integration.

Some bugs or broken things:

  • expanding related event messages to see full text doesn't work - only shows message title
  • related event messages only shows counterpart notices and hermes messages - should also show gcn circulars that reference NLE

Tighter HERMES integration:

  • Add button to submit NLE target candidates to HERMES with a message

Bonus:

  • Look into integrating treasure map into page
  • Look into integrating Alladin map of NLE into page

Labels: hermes, scimma, scimma-team, tom toolkit

Tasks:

  • Update dependencies of project
  • Expand creating event candidates from LVC_COUNTERPART messages
  • Expand related messages shown to include gcn circulars that reference NLE
  • Fix related messages shown to show full message text, not just title
  • Add button to submit event candidate targets to HERMES with a message

See:

@jchate6 jchate6 moved this to Staged in TOM Toolkit Nov 30, 2023
@jchate6 jchate6 moved this from Staged to Triage in TOM Toolkit Jan 18, 2024
@jchate6 jchate6 moved this from Triage to Backlog in TOM Toolkit Jan 19, 2024
@jchate6 jchate6 added bug Something isn't working dependencies Pull requests that update a dependency file labels Jan 20, 2024
@jchate6 jchate6 moved this from Backlog to Staged in TOM Toolkit Jan 30, 2024
@jchate6 jchate6 moved this from Staged to In progress in TOM Toolkit Feb 1, 2024
@jchate6 jchate6 moved this from In progress to Staged in TOM Toolkit Mar 29, 2024
@jchate6 jchate6 linked a pull request Jun 4, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from Staged to Closed in TOM Toolkit Jun 5, 2024
@jchate6 jchate6 reopened this Oct 1, 2024
@jchate6
Copy link
Contributor Author

jchate6 commented Oct 1, 2024

Re-activating because TOM_NonlocalizedEvents still needs to be updated.

@jchate6 jchate6 moved this from Closed to Triage in TOM Toolkit Oct 1, 2024
@jchate6
Copy link
Contributor Author

jchate6 commented Oct 17, 2024

@jchate6 jchate6 moved this from Triage to Backlog in TOM Toolkit Oct 17, 2024
@jchate6 jchate6 moved this from Backlog to Staged in TOM Toolkit Jan 6, 2025
@phycodurus phycodurus added the User Issue Raised by a user label Jan 13, 2025
@phycodurus phycodurus moved this from Staged to In progress in TOM Toolkit Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file User Issue Raised by a user
Projects
Status: In progress
3 participants