Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tom_lt: Fix/bring project up to date #38

Merged
merged 9 commits into from
Apr 16, 2024
Merged

Conversation

phycodurus
Copy link
Contributor

@phycodurus phycodurus commented Apr 12, 2024

  • adds a pyproject.toml file with poetry-dynamic-versioning (the setup.py remains but will be removed before we're done)
  • plumbs version through to template via get_facility_context_data(), etc (follows the pattern used for other Facilities and data services).
  • to the LTFacility class, adds and documents observation_forms class variable
  • refactors LTFacilty.get_form() to use observation_forms (I've left the old implementation for inspection and it will be remove later).

To continue the update, we're waiting on a test proposal from LT. (We have been in email contact with them and the test proposal should be forthcoming). In meantime, we can consider updating the supported instruments:

  • IO:I has been decommissioned; it's Form should be removed
  • MOPTOP is new; it needs a form of it's own
  • add LIRIC (IO:I replacement, currently available without pipeline (raw)) support

After the test proposal is available, we can take the module through a poetry-based PyPI release and remove setup.py.

@phycodurus phycodurus self-assigned this Apr 12, 2024
@phycodurus phycodurus requested a review from jchate6 April 12, 2024 23:45
@phycodurus phycodurus changed the title Fix/bring project up to date tom_lt: Fix/bring project up to date Apr 12, 2024
Copy link
Contributor

@jchate6 jchate6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

@jchate6 jchate6 self-requested a review April 15, 2024 22:23
@phycodurus phycodurus merged commit fc143f8 into dev Apr 16, 2024
10 checks passed
@phycodurus phycodurus deleted the fix/bring-project-up-to-date branch April 16, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Update Liverpool Telescope TOM app
2 participants