Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data harvested from brokers doesn't have assigned Data Product #1122

Closed
KKruszynska opened this issue Nov 20, 2024 · 2 comments
Closed

Data harvested from brokers doesn't have assigned Data Product #1122

KKruszynska opened this issue Nov 20, 2024 · 2 comments
Labels
enhancement New feature or request question Further information is requested User Issue Raised by a user

Comments

@KKruszynska
Copy link
Contributor

Currently, if a harvester downloads data into a TOM Toolkit-based system, the data points are stored as a ReducedDatum, but they don't have a linked Data Product. This is not the case if the user uploads the data. It is necessary for data sharing with the collaborators (for example, if there is Gaia data in my TOM, I cannot share it easily with the others through the Target page) and for efficiently fitting microlensing events tracked by MOP.

@KKruszynska KKruszynska added the enhancement New feature or request label Nov 20, 2024
@github-project-automation github-project-automation bot moved this to Triage in TOM Toolkit Nov 20, 2024
@rachel3834 rachel3834 added question Further information is requested User Issue Raised by a user labels Nov 20, 2024
@jchate6
Copy link
Contributor

jchate6 commented Nov 20, 2024

Hi @KKruszynska, we have hesitated to automatically create data products associated with the results of a broker query because as data comes in, the same query can generate different results each time. This could result in "overlapping" data products that contain mostly the same information with a few extra data points each time.

The preferred way to share data is to use the sharing options at the bottom of the photometry tab to upload data to Hermes, download data to a csv, or directly via the API of another TOM.
image

Alternatively you can share the entire target and any of its data from the "share" button under the target name on the target detail page:
image

I understand that this can be clunky with the current tables. We are working on adding filtering, pagination and sorting to these tables to make them more useful. see

If filtering out specific data points because they have already been shared is too cumbersome, it should be safe to share all the photometry data with another TOM and it should only ingest new data.

If you are sharing the data with a collaborator who doesn't have a TOMToolkit TOM, then hopefully the Download option should be what you need.

If you are trying to share spectroscopy, or any of the above features are not present in MOP, or are giving you trouble, let me know and I can help sort them out.

@rachel3834
Copy link
Contributor

Many thanks for explaining @jchate6 - I agree that reasoning makes sense for data that routinely updates.
The data sharing tools are a good way of manually downloading the data.
I'll close this thread because what we now think we actually need is an API, but that's a different issue....

@github-project-automation github-project-automation bot moved this from Triage to Closed in TOM Toolkit Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested User Issue Raised by a user
Projects
Archived in project
Development

No branches or pull requests

3 participants