Directly parse the brush instead of using the converter object. #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great, thanks. Any idea if this has anything to do with #45? |
I don't. I just PRed it because it was a change I made in Volte and I figured you would like it considering code clarity & cleanliness :p |
|
Ah fair enough. I didn't think it would be relevant, but I thought I'd ask because I'm not really sure where to go with that issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The converter type is moreso for conforming to a specific API, for the "constants" at the top of this file we don't need to use a converter. Especially when all that converter does is literally just
Brush.Parseanyways.