Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test] Bool64bitKey entries are not sorted in merged GameDataList #60

Open
Echocolat opened this issue Dec 2, 2024 · 1 comment
Open

[Test] Bool64bitKey entries are not sorted in merged GameDataList #60

Echocolat opened this issue Dec 2, 2024 · 1 comment
Labels
test Something already implemented that needs to be tested before release

Comments

@Echocolat
Copy link

GameDataListMerger looks like it does not insert new Bool64bitKey entries in sorted order, but instead at the very end of the array, which makes whatever is tied to said entries respawn forever, because the game does a binary search on this array.

Before TKMM:
image

After TKMM:
image
@ArchLeaders
Copy link
Member

This will not be reviewed until the rewrite.

@ArchLeaders ArchLeaders added waiting Waiting for external project updates test Something already implemented that needs to be tested before release and removed waiting Waiting for external project updates labels Dec 2, 2024
@ArchLeaders ArchLeaders changed the title Bool64bitKey entries are not sorted in merged GameDataList [Test] Bool64bitKey entries are not sorted in merged GameDataList Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
test Something already implemented that needs to be tested before release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ArchLeaders @Echocolat