Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smoother animations - Suggestion #14

Open
CaffeineOnIce opened this issue Dec 3, 2024 · 2 comments
Open

Smoother animations - Suggestion #14

CaffeineOnIce opened this issue Dec 3, 2024 · 2 comments

Comments

@CaffeineOnIce
Copy link

A small suggestion. If possible, kindly make the animations smoother. Like, for example, in a Phonograph fork, Vinyl, the animations are fluid. Whereas in Phocid, it's kinda snappy, and a bit jittery. Sorry for the nitpick.

Screen_Recording_20241203_233936_Phocid.mp4

Also, just in case, can you make the animation such that the miniplayer also moves upwards, while opening the player? The player just fades infront of the miniplayer. Would be nice, maybe.

@TJYSunset
Copy link
Owner

Fixed jumps in carousels caused by out-of-order animation calls in 4c39d5f. Still have a noticeable stutter due to discontinuous velocities and state update delays (probably could be mitigated by using hacks like "predictions", but I'm exhausted right now to try that approach).

@TJYSunset
Copy link
Owner

Slightly lengthened the player enter/exit animation in 87e3f7c

Also, just in case, can you make the animation such that the miniplayer also moves upwards, while opening the player? The player just fades infront of the miniplayer. Would be nice, maybe.

Animating the mini-player comes with double performance penalties and serious frame rate drops. Maybe it can be avoided, but not right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants