Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(feed): Video duration is always 00:00 #1348

Open
WaDadidou opened this issue Nov 14, 2024 · 2 comments · May be fixed by #1405
Open

bug(feed): Video duration is always 00:00 #1348

WaDadidou opened this issue Nov 14, 2024 · 2 comments · May be fixed by #1405
Assignees
@sujal-into
Labels
bug Something isn't working Paused Social Feed Everything related to the Social Feed

Comments

@WaDadidou
Copy link
Collaborator

The Videos duration is always 00:00 since the video has not been played

See FIXME here:

teritori-dapp/packages/components/socialFeed/Map/MapPosts/VideoMapPost.tsx

Line 69 in ebaa1d7

duration: videoPostMetadata.videoFile.videoMetadata?.duration, // FIXME: Known issue: Always 0. So, for videos, duration is set by playbackStatus, so it's 0 on the timer since the video is not started once

image
@WaDadidou WaDadidou added bug Something isn't working Social Feed Everything related to the Social Feed labels Nov 16, 2024
@n0izn0iz
Copy link
Collaborator

I think the client should add duration metadata on upload
There is not much incentives to mess with it IMO

@sujal-into sujal-into self-assigned this Nov 21, 2024
@sujal-into sujal-into linked a pull request Nov 21, 2024 that will close this issue
Open
@WaDadidou
Copy link
Collaborator Author

videoMetadata

I'm thinking that and approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sujal-into sujal-into

Labels
bug Something isn't working Paused Social Feed Everything related to the Social Feed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(feed): video duration calculated from Video component TERITORI/teritori-dapp
3 participants
@n0izn0iz @WaDadidou @sujal-into