Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme update #88

Merged
merged 8 commits into from
Jul 13, 2024
Merged

Readme update #88

merged 8 commits into from
Jul 13, 2024

Conversation

cyfyifanchen
Copy link
Collaborator

  • Consistency change
  • restructure modals and extension part
  • Adding 11labs as option in the config part
  • Adding .next to gitignore

Copy link
Contributor

@plutoless plutoless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the concept of interchangeable is not clear

Copy link
Collaborator

@sunshinexcode sunshinexcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyfyifanchen
Copy link
Collaborator Author

It means it can be changed to the other extension. I think I do have a little paragraph describes it just right above the table.

Another word choice is switchable, I ended up choose interchangeable, which I think is little bit better(I also asked GPT about it, he thinks the same). I am open to suggestions on any other better word choices.

@plutoless
Copy link
Contributor

It means it can be changed to the other extension. I think I do have a little paragraph describes it just right above the table.

Another word choice is switchable, I ended up choose interchangeable, which I think is little bit better(I also asked GPT about it, he thinks the same). I am open to suggestions on any other better word choices.

by far we do not yet have docs to describe how to switch extensions (you will need to manipulate manifest.json). the purpose of that section is to help developer understand the default set up, so emphasizing interchangeable is not very useful, and too early for a beginner.

i would suggest we only describe the default setup here. if needed, you can add an additional section abt how to switch extensions. also i would recommend we do this after our graph designer is ready.

@cyfyifanchen
Copy link
Collaborator Author

It means it can be changed to the other extension. I think I do have a little paragraph describes it just right above the table.
Another word choice is switchable, I ended up choose interchangeable, which I think is little bit better(I also asked GPT about it, he thinks the same). I am open to suggestions on any other better word choices.

by far we do not yet have docs to describe how to switch extensions (you will need to manipulate manifest.json). the purpose of that section is to help developer understand the default set up, so emphasizing interchangeable is not very useful, and too early for a beginner.

i would suggest we only describe the default setup here. if needed, you can add an additional section abt how to switch extensions. also i would recommend we do this after our graph designer is ready.

Updated.

@cyfyifanchen cyfyifanchen requested a review from plutoless July 11, 2024 23:32
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@cyfyifanchen cyfyifanchen requested a review from plutoless July 12, 2024 03:39
@cyfyifanchen
Copy link
Collaborator Author

cyfyifanchen commented Jul 12, 2024

image

Updated.

@plutoless plutoless merged commit a912780 into TEN-framework:main Jul 13, 2024
1 check passed
@cyfyifanchen cyfyifanchen deleted the readme-update branch August 1, 2024 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants