Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace missing images with black images not working for me when running it on a large number of beatmap folders #1

Open
justinhill12345 opened this issue May 29, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@justinhill12345
Copy link

not sure if this is where im supposed to be posting this message so i appologize in advance if its in the wrong place but im having and issue when i try to run the "replace missing images with black images" on my entire songs folder wich has roughly 17000 beatmap folders in it. it will do step 1 successfully and say theres roughly 500 images to replace but once it finishes checking all the folders it just stops like if i clicked a cancel button and doesnt replace the bg. no matter how many times i try it it does the same thing the only time it has worked for me is when i renamed my original song folder to songs2 and make a new empty songs folder in the osu directory and copy/paste 1 beatmap folder into the new songs folder. it will complete step 1 and 2 just fine and display the infobox saying that 1 bg was succesfully replaced and manually checking the beatmap folder after i can see the new bg that was created but if i try to do the same thing with 1000 beatmap folders from the original songs folder it will do the same thing as before and just complete step 1 then revert to the previous state before the button was pressed

@TCNOco
Copy link
Owner

TCNOco commented Jul 16, 2021

I will need to download a few thousand songs to test this out... I assume it's some kind of limitation? Will look into it :)

@TCNOco TCNOco added the bug Something isn't working label Jul 16, 2021
@heislera763
Copy link

I'm not sure if this is still being actively developed but I have found through some experimentation that this seems to be an issue with very long image file names. I used a python script to search for image names over 100 characters, then I did some further manual testing and found that the following sets will cause the bg replacement to fail:

308912 supercell - The Bravery (TV Edit)
617809 ryo(supercell) feat Hatsune Miku - ODDS&ENDS (Speed Up Ver)
650027 nameless - All I Need are Things I Like
778319 Hatsune Miku feat Wyz - Yukkuri To
779909 Misato Aki - DESIRE
911255 Matsuda Arisa (CV- Murakawa Rie) - Chou Jou Genki Show-Idol ch@ng!

Removing these from my songs folder allowed the program to run correctly.

@RaffElD
Copy link

RaffElD commented Nov 26, 2024

Turns out the app was set to build for 32bit (or rather not set to build for x64), which has a path length limit of 128 characters. As soon as there is a single element with 129 or more characters it dies.
So not actually bug, but a misconfigured build.
One quick build for x64 and there you go, all working fine. :D

And because I don't expect this to be fixed, I'll just add my build here:
TcNo-osu-Cleaner.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants