Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

what does success:true in Close mean after Cancel was accepted #354

Open
jiyoonie9 opened this issue Jul 15, 2024 — with Slack · 0 comments
Open

what does success:true in Close mean after Cancel was accepted #354

jiyoonie9 opened this issue Jul 15, 2024 — with Slack · 0 comments

Comments

Copy link
Contributor

maybe we need to expand on Close fields than just a Boolean now.

Close having value of success:true after Cancel could mean either 1) the Cancel was successful OR the exchange successfully completed (which is the opposite of what we want from an exchange with a Cancel that's accepted)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

1 participant