Making and closing from-SaveRAM movie clears casual SaveRAM

[YoshiRulz]

initially reported on Discord or maybe TASVideos Forum but I lost it

see also #2437

[Morilli]

This has nothing to do with saveram movie or not; .SaveRAM files are created based purely on the name of the movie. So if movie name == game name then the movie's save ram will overwrite the casual play one.

[CasualPokePlayer]

So if movie name == game name then the movie's save ram will overwrite the casual play one.

This is not an issue, the game name is placed in first before the movie name. In this case, you'd just end up having game name.game name.SaveRAM be created, which does not affect the casual save.

The issue would likely more come up once you stop playing back a movie. Then proceed to close the ROM/emulator. There's no movie playing, so BizHawk will happily overwrite your casual SaveRAM. The user can avoid this if stopping the movie came by closing the ROM/emulator in the first place and letting that do an implicit movie stop.

Note that this behavior might be relied on in some cases (I've definitely abused it at some point). A fix might best be flagging loaded SaveRAM being from a movie (note this would apply too for power-on and from savestate movies) upon stopping said movie, and warning on the first attempted flush if the user wants to overwrite their casual save.

[YoshiRulz]

Dupe of linked issue then? Either way, not getting into this release.

[CasualPokePlayer]

I think the linked issue is just wrong, there are separate SaveRAM files for TAStudio in the first place. If you proceed to close TAStudio however, you just go back to casual SaveRAM being used, as you aren't using TAStudio anymore.