Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freeze (E411) after pressing pad(3, 13)in clip instrument view (debug only) #2890

Open
RJ-Eckie opened this issue Nov 8, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@RJ-Eckie
Copy link
Contributor

RJ-Eckie commented Nov 8, 2024

Please describe the problem:

When in instrument clip view (synth, kit, midi) and pad 3, 13 (mod fx feedback) has been pressed, device will freeze on basically any instrumet action. Any parameter change, pressing any main grid pad. Display will display Error E411 most of the time. Sometimes display is a scrambled error message, sometimes display is unchanged.

Changing preset after pressing (3, 13) but before doing anything else avoids issue.

CV clips seem to be unaffected, as are song view, arranger view, automation view. No-repro on any release build. (Source, nightly, beta.)

What is the expected behavior?

No freezes

Is there a relevant Pull request?

No response

What hardware did you reproduce it with?

OLED

What firmware did you reproduce it with?

Built from community

What is the firmware name:

EB804DAA

If possible provide the steps to reproduce the issue and upload additional media:

  1. Open any synth, kit or midi clip view
  2. Press pad (3, 13)
  3. Turn a gold knob or press a grid pad
@m-m-adams
Copy link
Collaborator

I can't reproduce this either, not getting a crash

@RJ-Eckie
Copy link
Contributor Author

I can't reproduce this either, not getting a crash

Alright lemme try this on different versions as well

@RJ-Eckie
Copy link
Contributor Author

Can only reproduce this in debug build of current source (7759705A)

Test 1: Existing song, sequence some random notes. Then: press (3, 13), press any random note after that
Test 2: New song, new synth, sequence practically all pads, turn some gold knobs to see whether they still work. Then: press (3, 13), turn a gold knob

IMG_2505.mov

@m-m-adams
Copy link
Collaborator

Wow that's absolutely bizarre! I was trying to use the shortcut with shift and not just press the pad so I guess that's why it wasn't triggering

@m-m-adams m-m-adams added the bug Something isn't working label Nov 14, 2024
@m-m-adams
Copy link
Collaborator

m-m-adams commented Dec 1, 2024

I don't have a cause yet but the crashes come because the activeModControllableModelStack has a garbage but not zero patched param collection

image

If the value is actually zero you get the error code, otherwise it'll crash on trying to access unmapped memory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants