Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing catch in ice.js #820

Open
cjmyers opened this issue Feb 9, 2019 · 0 comments
Open

Missing catch in ice.js #820

cjmyers opened this issue Feb 9, 2019 · 0 comments

Comments

@cjmyers
Copy link
Collaborator

cjmyers commented Feb 9, 2019

There are many places in this file missing catch statements and some are causing recurrent failures:

getIceSequence: ERROR TypeError: Cannot read property 'childNodes' of undefined : https://public-registry.jbei.org/rest/file/8922/sequence/sbol2
(node:14902) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'childNodes' of undefined
at RdfLibParser.parse (/home/deploy/synbiohub_dev/node_modules/rdf-parser-rdfxml/index.js:226:29)
at /home/deploy/synbiohub_dev/node_modules/rdf-parser-rdfxml/index.js:624:31
at new Promise ()
at RdfXmlParser.process (/home/deploy/synbiohub_dev/node_modules/rdf-parser-rdfxml/index.js:577:10)
at /home/deploy/synbiohub_dev/node_modules/rdf-parser-abstract/index.js:19:10
at new Promise ()
at RdfXmlParser.AbstractParser.parse (/home/deploy/synbiohub_dev/node_modules/rdf-parser-abstract/index.js:18:10)
at loadNextSource (/home/deploy/synbiohub_dev/node_modules/sboljs/lib/load/rdf/loadRDF.js:79:16)
at load (/home/deploy/synbiohub_dev/node_modules/sboljs/lib/load/rdf/loadRDF.js:75:5)
at SBOLDocument.loadRDF (/home/deploy/synbiohub_dev/node_modules/sboljs/lib/SBOLDocument.js:842:9)
at Function.loadRDF (/home/deploy/synbiohub_dev/node_modules/sboljs/lib/SBOLDocument.js:807:22)
at Request.request [as _callback] (/home/deploy/synbiohub_dev/lib/ice.js:293:26)
at Request.self.callback (/home/deploy/synbiohub_dev/node_modules/request/request.js:185:22)
at emitTwo (events.js:126:13)
at Request.emit (events.js:214:7)
at Request. (/home/deploy/synbiohub_dev/node_modules/request/request.js:1161:10)
(node:14902) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 17)

@cjmyers cjmyers added this to the SBH 1.5.0 milestone Feb 9, 2019
@cjmyers cjmyers self-assigned this Feb 9, 2019
@cjmyers cjmyers added reliability and removed bug labels Feb 9, 2019
@cjmyers cjmyers modified the milestones: SBH 1.5.0, SBH 1.6.0 May 1, 2019
@cjmyers cjmyers modified the milestones: SBH 1.6.0, SBH 1.5.2 Jun 21, 2019
@cjmyers cjmyers removed the Priority label Jul 9, 2019
@cjmyers cjmyers modified the milestones: SBH 1.5.2, SBH 1.6.0 Jul 26, 2019
@cjmyers cjmyers modified the milestones: SBH 1.6.0, SBH 2.0.0 May 29, 2020
@cjmyers cjmyers removed their assignment Nov 30, 2024
@cjmyers cjmyers modified the milestones: SBH 2.0.0, SBH 1.7.0 Dec 24, 2024
@cjmyers cjmyers modified the milestones: SBH 1.7.0, SBH 2.0.0 Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant