The download button doesn't disappear based on the eval endpoint

[JMante1]

At the moment for download plugins the download button doesn't disappear based on the eval endpoint. E.g. for sbol2excel.synbiohub.org it appears on component def pages even though it should only appear on collection pages. This leads to endless wait for a download as it won't send a run request.

[cjmyers]

I've poked around a bit, and I cannot figure out how this is supposed to work. The download plugins are created here:

synbiohub/lib/views/topLevelView.js

Line 219 in 9d7556f

}).then(plugins.getDownloadPlugins)

However, I cannot find how the evaluate endpoint gets called and the download buttons updated.

@3ach Do you recall how the evaluate button update is implemented?

[3ach]

Hi — When a page is rendered, the server creates a new stream handle for each plugin on the page. Evaluate is called at this time. ( https://github.com/SynBioHub/synbiohub/blob/9d7556f7b2316d96d633d3d2783c2cded57209b7/lib/api/stream.js#L94). If evaluate gives back a ‘no’ or another bad response, we remember that. (Set the handle state to ‘gone’.) There is a stream API endpoint which accepts a handle as a parameter. When it’s called it will either tell the client that the stream is gone/deleted with a 404 (which will cause the client to remove the button, https://github.com/SynBioHub/synbiohub/blob/9d7556f7b2316d96d633d3d2783c2cded57209b7/browser/plugin.js#L40) to try again in 1s, or give the plug-in content back. Reading the code, it looks though like the download *buttons* don’t do this. They link to the stream *page*, which is a really basic wrapper around the JavaScript used for enfer the plug-in panel. To make the download button work how you want, you’d want to modify browser JS to start polling for updates on page load.

…

On Wed, Jun 1, 2022 at 07:52 cjmyers ***@***.***> wrote: I've poked around a bit, and I cannot figure out how this is supposed to work. The download plugins are created here: https://github.com/SynBioHub/synbiohub/blob/9d7556f7b2316d96d633d3d2783c2cded57209b7/lib/views/topLevelView.js#L219 However, I cannot find how the evaluate endpoint gets called and the download buttons updated. @3ach <https://github.com/3ach> Do you recall how the evaluate button update is implemented? — Reply to this email directly, view it on GitHub <#1502 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAXTGTOZCMFH4J7COXTU5PLVM6PM3ANCNFSM5XRQRJHA> . You are receiving this because you were mentioned.Message ID: ***@***.***>