-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SEP 058 -- Aliases #124
Comments
Are aliases meant to only be for SBOL objects? I wonder if aliases and instanceof should be integrated into a singular proposal? That way the same object in GenBank, Addgene, SBOL, etc can all be addressed and looked up in the same manner. |
I believe that importing materials from outside of SBOL needs to be handled separately, since the means of accessing those objects is necessarily different, and they need to be converted when imported in any case. I would also be reluctant to mess with the semantics of instanceOf, which are well established and used by a number of tools. |
I take your point, however, I would like to be clearer on instanceOf versus alias. In the current proposal Alias is for any similar SBOL objects (there may be different triples but the sequence must be the same?). Whilst instanceOf is for any similar (sequence must be the same) external SBOL objects? Is the purpose of alias mainly to allow merging in future, to act explicitly as alternative names (in a more ontological sense), or to indicate that there may be more information about the sequence elsewhere? |
The two are very different: the Perhaps you are thinking of |
You are right. Was thinking of ExternallyDefined (Monday morning!). I am not sure that externallyDefined is orthogonal to alias. Aren't both ways of referring to additional instances of an object (though one in SBOL and the other outside)? For the question are there alternative names/versions of componentA, wouldn't you want to know it is also an iGEM component, a GenBank component, and there is an alternative SBOL version? |
Here is the distinction that I see:
|
Given that this proposal had an overall good reception in discussions at HARMONY next week, and that there have been no further concerns raised in the past five days, I would like to move this forward for a vote. If there are any additional concerns, please raise them now. |
With the implementation of "resolve aliases " after reading a |
@Gonza10V There are two key cases where it is advantageous to use an alias:
|
@jakebeal Per discussion in SBOL Editors meeting there are some concerns about its implementation, as it would create more work for library maintainers like @tcmitchell and @goksel . The libraries still dont cover 3.1 and we will have a 3.2 specification. Does |
The We could, of course, implement |
I agree with @jakebeal that this must be implemented in SBOL as a class. Validation rules are going to need to be updated. Also, in SBOL, the standard practice is the specification leads the implementation. We do not typically implement things unless they are in the specification, so if something is a good idea, we add it to the specification first, and the libraries catch up. |
I'm going to preface this by saying that having an Alias as a class is great and will be a very useful for SBOL in general. That being said, I think we will need to set expectations as to the expected timeline for incorporating these changes in the libraries and tools (and this is more of a generic comment and not targeted at this specific SEP - although it is highly relevant here). If we want to vote this in now because it is a good idea but expect this to be incorporated at a later date (let's say a year from now), that's great. If the expectation is that these must be incorporated in the libraries immediately, I think that will be difficult unless we find interested members of the community who would like to contribute to the libraries and/or the library developers have the bandwidth to update their respective libraries. I'm currently working on trying to increase our community engagement - but this is going to take some time. |
I'm fine with setting a schedule for an expected adoption time. I just want this to be an intentional choice and not having this sitting in limbo. Among other things, that will allow libraries to move at different paces in implementation. |
That's perfectly reasonable. We are going to send this out for voting soon. We will schedule this immediately after the editor voting (you'll see an email for this very soon). |
@PrashantVaidyanathan : I don't believe I've seen a schedule for the vote yet. Have I missed something? |
We will be scheduling this vote next week - so it's in the pipeline. We were waiting for the SBOL editor voting to end first to avoid confusion with the voting process. |
Now in the queue for votation, spected to be started on Friday 28. |
Genetic parts often have more than one identifier, either for historical reasons or because there are "nickname" versions of an identifier. This SEP proposes a means of tracking the relationship between the canonical name for a part (or other object) and a set of aliases that can be used to redirect to it from other identities.
Full draft in: https://github.com/SynBioDex/SEPs/blob/master/sep_058.md
The text was updated successfully, but these errors were encountered: