-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for reading / writing compressed files #4
Comments
I did an experiment with zstr streams: void get_root_elements(const char *filename){
pugi::xml_document doc;
pugi::xml_parse_result result;
std::string x(filename);
if(x.rfind(".") != std::string::npos && x.substr(x.rfind(".")+1) == "gz"){
std::ifstream F;
F.open(x);
zstr::istream Z(F);
result = doc.load(Z);
} else {
result = doc.load_file(filename);
}
if(!result)
throw std::runtime_error("Could not load XML file " + std::string(filename) + ".");
for(pugi::xml_node node= doc.first_child(); node; node = node.next_sibling()){
if(std::strcmp(node.name(), "rr_graph") == 0){
count_rr_graph(node);
alloc_arenas();
load_rr_graph(node, &rr_graph);
}
else throw std::runtime_error("Invalid root-level element " + std::string(node.name()));
}
} Artix 7 rr_graph run with uncompressed file(922 MB)(without errno checking after strtol calls): With gzip-compressed file: |
Is that with or without a hot disk cache? Can you try flushing that? |
It's with a hot disk cache. Without the file in the cache, the reading time can jump to 11 seconds or so. |
@duck2 - How does the time between with gzip and without gzip compare without file in the disk cache? |
Once SAX parsing support is complete (#3), a compressed one pass SAX parser may be a good compromise between CPU/disk/memory usage. Unclear if a two pass SAX + compression would have good numbers. |
See https://github.com/mithro/duck2-gsoc/issues/16
The text was updated successfully, but these errors were encountered: