Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make generated code match a style guide #11

Open
mithro opened this issue Jul 7, 2019 · 1 comment
Open

Make generated code match a style guide #11

mithro opened this issue Jul 7, 2019 · 1 comment

Comments

@mithro
Copy link
Member

mithro commented Jul 7, 2019

It would be good if the generated code matched an existing style guide. I have a lot of experience with the Google C++ style guide @ https://google.github.io/styleguide/cppguide.html As you are using exceptions which the Google C++ style guide forbids, maybe that isn't a good match.

Since this code is supposed to end up in VtR, generating something which matches the clang-format at https://github.com/SymbiFlow/vtr-verilog-to-routing/blob/master%2Bwip/.clang-format might be a good idea too.

@duck2
Copy link
Member

duck2 commented Aug 7, 2019

I'm thinking about getting rid of the exceptions, since it's not clear what happens to the allocated memory so far after parsing fails.

For vpr, running make format after copying the generated files works OK. It would be even better to run clang-format only on the generated files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants