-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New features, sync with upstream #4
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because that might depend on values read from the header which we have not read yet.
separate debug log messages from error log messages
different compression) and 4,8 (without compression).
songs in one file.
basically enables looping the whole file.
unknown, or 3) the format is overridden with -f detect or a similar unknown format.
output file if we have a successful conversion.
(dependencies on h files are automatic wit CMake), add utfcpp to include directories.
… looping and forced detection
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
The last few days I have been working on adlib2vgm. List of changes I made:
I kept your coding style intact, i.e. true tabs, tab width 8.
You might want to remove the 'not 100% compatible with VGMPlay' remark from README.md. I have not encountered any problems anymore with https://github.com/vgmrips/vgmplay or https://github.com/adplug/adplay-unix/ .
If you want further things done before merging, please let me know.
Kind regards,
Ivo