Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New features, sync with upstream #4

Merged
merged 132 commits into from
Oct 12, 2023
Merged

New features, sync with upstream #4

merged 132 commits into from
Oct 12, 2023

Conversation

ivop
Copy link
Contributor

@ivop ivop commented Oct 9, 2023

Hi,

The last few days I have been working on adlib2vgm. List of changes I made:

  • verbose conversion messages under -v option
  • enabled messages in loaders/drivers, visible with -d option
  • added all adplug loaders of which I could find a sample file
  • synced with upstream, lots of fixes in the last two years
  • added subsong support
  • added looping support
  • added GD3 support (metadata)
  • fixed low volume on conversions, only one of the OPL2/OPL3 clocks is set
  • slightly improved timing
  • rewrites/simplification of other logic
  • added auto detection
  • use shorter wait commands if possible
  • basic regression test in tools directory
  • made code work on big-endian, too
  • added option to export gzip compressed .vgz directly
  • perhaps more, I forgot ;)

I kept your coding style intact, i.e. true tabs, tab width 8.

You might want to remove the 'not 100% compatible with VGMPlay' remark from README.md. I have not encountered any problems anymore with https://github.com/vgmrips/vgmplay or https://github.com/adplug/adplay-unix/ .

If you want further things done before merging, please let me know.

Kind regards,
Ivo

ivop added 30 commits October 6, 2023 05:14
because that might depend on values read from the header which we have
not read yet.
separate debug log messages from error log messages
different compression) and 4,8 (without compression).
ivop and others added 28 commits October 8, 2023 13:00
unknown, or 3) the format is overridden with -f detect or a similar
unknown format.
output file if we have a successful conversion.
(dependencies on h files are automatic wit CMake), add utfcpp to include
directories.
@ReimuNotMoe ReimuNotMoe merged commit 31210b5 into SudoMaker:master Oct 12, 2023
1 check passed
@ReimuNotMoe
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants