Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stuart::Client is missing methods #2

Open
stem opened this issue Apr 10, 2018 · 1 comment
Open

Stuart::Client is missing methods #2

stem opened this issue Apr 10, 2018 · 1 comment

Comments

@stem
Copy link

stem commented Apr 10, 2018

Hello,

I would expect Stuart::Client to provide methods to help me create a job without knowing about the http details (like JSON.generate or PUT / POST method for example)

Do you plan on adding methods to this abstraction class ?

@maximilientyc
Copy link
Contributor

Hey @stem !

Thank you for your message and sorry for the late reply!

Yes indeed the objective is to have as much business methods as possible within the Stuart::Client class, I added only one to show the path to contributors!

You can have a look at contributions that has been made on the Client class of the PHP library: https://github.com/StuartApp/stuart-client-php/blob/master/src/Stuart/Client.php.

Feel free to create pull requests, we will be very reactive for the code review.
Best 👋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants