Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZEUS-4591] Fix video playing in background when switching #23

Conversation

artem-y-pamediagroup
Copy link
Contributor

Jira

  • ZEUS-4591
  • part of the fix for SE-973, SE-1032

Changes

  • fixed removal of action handler targets from MPRemoteCommandCenter, which were capturing an instance of the player
  • got rid of the reference to SwiftUI view in the BitmovinPlayerPlugin, used a weak reference to the player itself, in order to make the lifecycle of SwiftUI view and its dependencies predictable
  • for this, added a new init for the BitMovinPlayerView to enable passing the player from outside of the view
  • added creation and assignment of the uiConfig into the setup method of the plugin, so when the player is created outside it's also set up properly
  • inside PlaybackUIView, put the state updates onto the main queue

@artem-y-pamediagroup artem-y-pamediagroup changed the title [ZEUS-4591] Video playing in background when switching [ZEUS-4591] Fix video playing in background when switching Jul 11, 2024
@artem-y-pamediagroup artem-y-pamediagroup merged commit f7f7727 into release/1.2.0 Jul 12, 2024
3 checks passed
@artem-y-pamediagroup artem-y-pamediagroup deleted the bugfix/ZEUS-4591-video-playing-in-background-when-switching branch July 12, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants