Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper optic error reporting #147

Open
mikkeldenker opened this issue Feb 11, 2024 · 0 comments
Open

Add proper optic error reporting #147

mikkeldenker opened this issue Feb 11, 2024 · 0 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@mikkeldenker
Copy link
Member

If one tries to perform a search with an optic with syntax errors, the search fails and shows a 500 internal server error to the user without any details on what went wrong.
The parsing error should instead be properly propagated so the user can see exactly where the syntax error is.

I think we might need to change how non-ok responses are handled in abeye so we can properly catch and handle the errors (preamble.ts#L40-L49).
We will also somehow need to add the full parsing error to the body of the 400 http response from Stracts API, so this can be shown to the user.

@mikkeldenker mikkeldenker added bug Something isn't working enhancement New feature or request labels Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant