From 6fbc8b9765758cc68df2a38a1c1fef4b17bb3aff Mon Sep 17 00:00:00 2001 From: Stefan Bratanov Date: Mon, 23 Oct 2023 13:57:53 +0100 Subject: [PATCH] as per feedback --- .../phase0/forkchoice/StubBlobSidecarManager.java | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/eth-reference-tests/src/referenceTest/java/tech/pegasys/teku/reference/phase0/forkchoice/StubBlobSidecarManager.java b/eth-reference-tests/src/referenceTest/java/tech/pegasys/teku/reference/phase0/forkchoice/StubBlobSidecarManager.java index 98cb59d51c6..240a1727bf5 100644 --- a/eth-reference-tests/src/referenceTest/java/tech/pegasys/teku/reference/phase0/forkchoice/StubBlobSidecarManager.java +++ b/eth-reference-tests/src/referenceTest/java/tech/pegasys/teku/reference/phase0/forkchoice/StubBlobSidecarManager.java @@ -36,7 +36,7 @@ import tech.pegasys.teku.statetransition.blobs.BlobSidecarManager; import tech.pegasys.teku.statetransition.validation.InternalValidationResult; -/** Simplified version of {@link BlobSidecarManager} which is used in reference tests */ +/** Simplified version of {@link BlobSidecarManager} which is used in fork choice reference tests */ class StubBlobSidecarManager implements BlobSidecarManager { private final Map blobsAndProofsByBlockRoot = new HashMap<>(); @@ -57,7 +57,7 @@ public void prepareBlobsAndProofsForBlock( public SafeFuture validateAndPrepareForBlockImport( final SignedBlobSidecar signedBlobSidecar) { return SafeFuture.failedFuture( - new UnsupportedOperationException("Not available in fork_choice reference tests")); + new UnsupportedOperationException("Not available in fork choice reference tests")); } @Override @@ -96,16 +96,16 @@ public SafeFuture getAvailabilityCheckResult() if (blobsAndProofs == null) { return SafeFuture.completedFuture(BlobSidecarsAndValidationResult.NOT_REQUIRED); } - return SafeFuture.completedFuture(validateBatch(block, blobsAndProofs)); + return SafeFuture.completedFuture(validateImmediately(block, blobsAndProofs)); } @Override public BlobSidecarsAndValidationResult validateImmediately( final List blobSidecars) { - throw new UnsupportedOperationException("Not available in fork_choice reference tests"); + throw new UnsupportedOperationException("Not available in fork choice reference tests"); } - public BlobSidecarsAndValidationResult validateBatch( + private BlobSidecarsAndValidationResult validateImmediately( final SignedBeaconBlock block, final BlobsAndProofs blobsAndProofs) { final List kzgCommitments = BeaconBlockBodyDeneb.required(block.getMessage().getBody()) @@ -131,7 +131,7 @@ public BlobSidecarsAndValidationResult validateBatch( @Override public BlobSidecarsAndValidationResult createAvailabilityCheckerAndValidateImmediately( final SignedBeaconBlock block, final List blobSidecars) { - throw new UnsupportedOperationException("Not available in fork_choice reference tests"); + throw new UnsupportedOperationException("Not available in fork choice reference tests"); } private record BlobsAndProofs(List blobs, List proofs) {}