Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing symbols in ADQL #66

Closed
olebole opened this issue Nov 13, 2023 · 2 comments
Closed

Missing symbols in ADQL #66

olebole opened this issue Nov 13, 2023 · 2 comments

Comments

@olebole
Copy link
Contributor

olebole commented Nov 13, 2023

While trying to update the Debian packages of Starjava, In encountered a compilation error with the "vo" package; specifically missing symbols. From the log:

build:
    [mkdir] Created dir: /build/starjava-vo-0.2+2023.11.01/build/classes
    [javac] Compiling 117 source files to /build/starjava-vo-0.2+2023.11.01/buil
d/classes
    [javac] /build/starjava-vo-0.2+2023.11.01/src/main/uk/ac/starlink/vo/AdqlVersion.java:39: error: cannot find symbol
    [javac]     private final ADQLParser.ADQLVersion volltVersion_;
    [javac]                             ^
    [javac]   symbol:   class ADQLVersion
    [javac]   location: class ADQLParser
[…]
    [javac] /build/starjava-vo-0.2+2023.11.01/src/main/uk/ac/starlink/vo/AdqlValidator.java:5: error: cannot find symbol
    [javac] import adql.db.DBIdentifier;
    [javac]               ^
    [javac]   symbol:   class DBIdentifier
    [javac]   location: package adql.db
    [javac] /build/starjava-vo-0.2+2023.11.01/src/main/uk/ac/starlink/vo/AdqlValidator.java:13: error: package adql.parser.feature does not exist
    [javac] import adql.parser.feature.FeatureSet;
    [javac]                           ^
    [javac] /build/starjava-vo-0.2+2023.11.01/src/main/uk/ac/starlink/vo/AdqlValidator.java:14: error: package adql.parser.feature does not exist
    [javac] import adql.parser.feature.LanguageFeature;
    [javac]                           ^
    [javac] /build/starjava-vo-0.2+2023.11.01/src/main/uk/ac/starlink/vo/AdqlValidator.java:15: error: package adql.parser.grammar does not exist
    [javac] import adql.parser.grammar.ParseException;
    [javac]                           ^
 […]

I am using the adql package from @gmantele (part of gmantele/vollt); originally the source jar file provided with version 1.5), but now updated to the lastest master [1481ccb), which worked until Topcat 4.8.7 & friends).

Are the changes required for adql somewhere available? I couldn' find them on Github.

@mbtaylor
Copy link
Member

Hi @olebole. To support ADQL 2.1, TOPCAT v4.8-8 and later are using an adqlLib version on branch adql2.1, namely gmantele/vollt@8b88a44779 (see the history of vo/src/lib/adqlParser.jar). If and when ADQL 2.1 functionality makes it into the master branch or a public release of VOLLT, that will be updated.

@olebole
Copy link
Contributor Author

olebole commented Dec 9, 2023

This is resolved with the adql-2.0-beta version, so I am closing.

@olebole olebole closed this as completed Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants