Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

java.lang.NullPointerException in Section UUC of taplint tests #63

Closed
esabol opened this issue Apr 13, 2022 · 3 comments
Closed

java.lang.NullPointerException in Section UUC of taplint tests #63

esabol opened this issue Apr 13, 2022 · 3 comments

Comments

@esabol
Copy link

esabol commented Apr 13, 2022

Hi, Mark. I just upgraded our stilts.jar to v3.4-4, and got a java.lang.NullPointerException when running taplint. Obviously, we didn't get this error with v3.4-3, and we run taplint frequently (like daily), so it's specific to v3.4-4.

Section UUC: Check column units and UCDs are legal
I-UUC-UCDV-1 UCD validation details: Ucidy version 1.2, UCD words version EN-UCD1+-1.4, UCD deprecated words version EN-UCD1+-1.4
java.lang.NullPointerException
        at uk.ac.starlink.ttools.votlint.UnitStatus.createStatus(UnitStatus.java:109)
        at java.util.HashMap.computeIfAbsent(HashMap.java:1127)
        at java.util.Collections$SynchronizedMap.computeIfAbsent(Collections.java:2672)
        at uk.ac.starlink.ttools.votlint.UnitStatus.getStatus(UnitStatus.java:69)
        at uk.ac.starlink.ttools.taplint.UnitUcdStage.lambda$createUnitChecker$0(UnitUcdStage.java:171)
        at uk.ac.starlink.ttools.taplint.UnitUcdStage.reportBadValues(UnitUcdStage.java:113)
        at uk.ac.starlink.ttools.taplint.UnitUcdStage.run(UnitUcdStage.java:78)
        at uk.ac.starlink.ttools.taplint.TapLinter$4.execute(TapLinter.java:259)
        at uk.ac.starlink.ttools.task.LineInvoker.invoke(LineInvoker.java:303)
        at uk.ac.starlink.ttools.Stilts.main(Stilts.java:50)
@mbtaylor
Copy link
Member

Oh dear, you seem to have caught a crab, sorry about that. This is related to some new code that attempts to provide better advice about what an unrecognised unit probably ought to look like, but it fails for units which are unknown in VOUnits syntax but recognised in some other unit syntax variants.

I've made a fix at fb1a7b3; this will be in the next public release, but until then you can find a pre-release version with the fix at http://andromeda.star.bristol.ac.uk/releases/stilts/pre/stilts.jar . If you don't want to do that you can revert to v3.4-3.

@esabol
Copy link
Author

esabol commented Apr 15, 2022

Thanks, Mark. I've downloaded your pre-release stilts.jar, and it works great. Thanks for the quick fix. Closing.

@esabol esabol closed this as completed Apr 15, 2022
@mbtaylor
Copy link
Member

Thanks a lot for reporting the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants