Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taplint/votlint UNKNOWN_UNIT warnings are reported without the first character of unit string #61

Closed
esabol opened this issue Feb 8, 2022 · 2 comments

Comments

@esabol
Copy link

esabol commented Feb 8, 2022

taplint and votlint both report warnings like the following:

WARNING (l.19, c.94): Bad VOUnit "degree" (UNKNOWN_UNIT): Unknown unit "egree"
WARNING (l.28, c.79): Bad VOUnit "mjd" (UNKNOWN_UNIT): Unknown unit "jd"

It seems like a bug that it says "egree" and "jd" instead of "degree" and "mjd" in the warning? It gets the units correct initially where it says "Bad VOUnit ...", but then it removes the first character where it says "Unknown unit ..."

@mbtaylor
Copy link
Member

mbtaylor commented Feb 8, 2022

It has interpreted these as a deci-egree and a milli-jd respectively, where the "egree" and "jd" are unrecognised, but syntactically permissible units. I agree this is a bit unintuitive. These messages are generated by a third-party library Unity, and in fact there are some changes in progress to improve these messages, but for one reason and another the updates are not ready to apply yet. So things might look better in future releases. But in the mean time it's probably best to take the text of these unit warnings as a hint that there's something non-compliant somewhere.

@esabol
Copy link
Author

esabol commented Feb 8, 2022

Ah, OK. Thanks for the explanation.

@esabol esabol closed this as completed Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants