Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix segfault-failing tests not getting picked up as failing checks in report #912

Open
cgokmen opened this issue Sep 27, 2024 · 1 comment · Fixed by #913
Open

Fix segfault-failing tests not getting picked up as failing checks in report #912

cgokmen opened this issue Sep 27, 2024 · 1 comment · Fixed by #913
Assignees
Labels
bug Something isn't working

Comments

@cgokmen
Copy link
Contributor

cgokmen commented Sep 27, 2024

Currently, if a test fails with a segfault etc. that prevents the writing of the report, this line doesnt catch it:

if grep -Eq 'failures="[1-9][0-9]*"|errors="[1-9][0-9]*"' ${{ matrix.test_file }}.xml; then

And there's nothing preventing the report from succeeding when certain tests DONT have outputs.

So if our tests fail hard enough they just disappear from the list of tests :(

@cgokmen cgokmen added the bug Something isn't working label Sep 27, 2024
@cgokmen
Copy link
Contributor Author

cgokmen commented Sep 27, 2024

FYI @ChengshuLi @cremebrule

@cgokmen cgokmen changed the title Fix failing tests not getting picked up by the runners Fix segfault-failing tests not getting picked up as failing checks in report Sep 27, 2024
@cgokmen cgokmen linked a pull request Oct 4, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants